Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #475: add doc about GKE node pools in terraform #5289

Merged

Conversation

pgier
Copy link
Contributor

@pgier pgier commented Oct 6, 2021

Adds brief explanation about why GKE node pools should be defined separately from the cluster resource
when using terraform.

Related to issue hashicorp/terraform-provider-google#475. PR #1329 added an example to the terraform docs that indicates that it is recommended to create node pools separately from the cluster definition, but there was no information in the docs about why this is recommended. This PR

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
container: Added note about why node pools should be defined separately from the cluster

Short explanation about why GKE node pools should be defined separately from the cluster resource
when using terraform.
@google-cla google-cla bot added the cla: yes label Oct 6, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+))

@nat-henderson nat-henderson merged commit 68a4b12 into GoogleCloudPlatform:master Oct 6, 2021
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
…orm (GoogleCloudPlatform#5289)

Short explanation about why GKE node pools should be defined separately from the cluster resource
when using terraform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants