Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add common compile/copy for terraform #541

Merged
merged 1 commit into from
Oct 12, 2018
Merged

add common compile/copy for terraform #541

merged 1 commit into from
Oct 12, 2018

Conversation

danawillow
Copy link
Contributor

This scans the files in the directory to copy over the correct test ones. This way, we don't have to maintain the list by hand, and we also can make sure we generate into the correct folder for ga vs beta.

No downstream changes expected.


[all]

[terraform]

[puppet]

[puppet-bigquery]

[puppet-compute]

[puppet-container]

[puppet-dns]

[puppet-logging]

[puppet-pubsub]

[puppet-resourcemanager]

[puppet-sql]

[puppet-storage]

[chef]

[chef-compute]

[chef-container]

[chef-dns]

[chef-logging]

[chef-spanner]

[chef-sql]

[chef-storage]

[ansible]

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 9, 2018

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, but they were closed.

@danawillow
Copy link
Contributor Author

Ah yup ok need to stop generating at beta first.

@danawillow
Copy link
Contributor Author

This is blocked on #543

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit ae485bb) have been included in your existing downstream PRs.

@modular-magician modular-magician merged commit 355fbf1 into master Oct 12, 2018
@danawillow danawillow deleted the tfcommon branch October 12, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants