Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote boot_disk_kms_key of google_container_node_pool to GA #5521

Merged

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Dec 6, 2021

Fixes: hashicorp/terraform-provider-google#10650

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: promoted `node_config.0.boot_disk_kms_key` of `google_container_node_pool` to GA

Co-authored-by: upodroid <cy@borg.dev>
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 68 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 4 files changed, 28 insertions(+), 46 deletions(-))

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the tests pass.


func TestAccContainerCluster_withBootDiskKmsKey(t *testing.T) {
// KMS key has calculated next rotation time
skipIfVcr(t)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this no longer necessary? What changed? Or was it unnecessary in the first place?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is obviated by BootstrapKMSKeyInLocation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the test is more efficient now by reusing bootstrap kms keys and making VCR usable

@melinath
Copy link
Member

melinath commented Dec 9, 2021

/gcbrun

@melinath
Copy link
Member

melinath commented Dec 9, 2021

@melinath
Copy link
Member

melinath commented Dec 9, 2021

Is there a test that exercises this feature for google_container_node_pool as well that needs to be promoted?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 68 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 4 files changed, 28 insertions(+), 46 deletions(-))

@upodroid
Copy link
Contributor Author

upodroid commented Dec 9, 2021

Is there a test that exercises this feature for google_container_node_pool as well that needs to be promoted?

A separate one isn't needed as the node_config.go logic is used in the cluster resource and all the fields are ForceNew anyway

@melinath melinath merged commit 18a87ae into GoogleCloudPlatform:master Jan 4, 2022
xuchenma pushed a commit to xuchenma/magic-modules that referenced this pull request Jan 7, 2022
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GKE : Move boot_disk_kms_key to GA
3 participants