-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote boot_disk_kms_key
of google_container_node_pool
to GA
#5521
Promote boot_disk_kms_key
of google_container_node_pool
to GA
#5521
Conversation
Co-authored-by: upodroid <cy@borg.dev>
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @melinath, please review this PR or find an appropriate assignee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming the tests pass.
|
||
func TestAccContainerCluster_withBootDiskKmsKey(t *testing.T) { | ||
// KMS key has calculated next rotation time | ||
skipIfVcr(t) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this no longer necessary? What changed? Or was it unnecessary in the first place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is obviated by BootstrapKMSKeyInLocation
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the test is more efficient now by reusing bootstrap kms keys and making VCR usable
/gcbrun |
GA test run of the new test: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/229918 |
Is there a test that exercises this feature for google_container_node_pool as well that needs to be promoted? |
A separate one isn't needed as the node_config.go logic is used in the cluster resource and all the fields are ForceNew anyway |
Co-authored-by: upodroid <cy@borg.dev>
Co-authored-by: upodroid <cy@borg.dev>
Fixes: hashicorp/terraform-provider-google#10650
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)