Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy terraform resources and data_sources from magic modules #556

Merged

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Oct 12, 2018

copying all of the resource_* and data_source* files that are not otherwise generated by MM


[all]

[terraform]

Copy legacy resources from magic modules to terraform

[puppet]

[puppet-bigquery]

[puppet-compute]

[puppet-container]

[puppet-dns]

[puppet-logging]

[puppet-pubsub]

[puppet-resourcemanager]

[puppet-sql]

[puppet-storage]

[chef]

[chef-compute]

[chef-container]

[chef-dns]

[chef-logging]

[chef-spanner]

[chef-sql]

[chef-storage]

[ansible]

@chrisst chrisst requested a review from danawillow October 12, 2018 16:33
@chrisst chrisst force-pushed the generate-all-the-things branch from 24d0d08 to dc39829 Compare October 12, 2018 16:33
@chrisst chrisst force-pushed the generate-all-the-things branch from dc39829 to 4594ec6 Compare October 12, 2018 19:43
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I think your original instinct of using provider/terraform instead of templates/terraform was the right one. You're welcome to do that in here (and move the tests) or in a follow-up.

@chrisst chrisst changed the title Copy a single resource blindly from magic modules Copy terraform resources and data_sources from magic modules Oct 12, 2018
@chrisst chrisst force-pushed the generate-all-the-things branch from f3184d1 to 6e819f7 Compare October 12, 2018 23:22
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#2254

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 76e2c32) have been included in your existing downstream PRs.

Tracked submodules are build/puppet/_bundle build/puppet/auth build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/spanner build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/_bundle build/chef/auth build/chef/compute build/chef/sql build/chef/storage build/chef/spanner build/chef/container build/chef/dns build/chef/iam build/terraform build/ansible.
@modular-magician modular-magician merged commit 8d2f6ea into GoogleCloudPlatform:master Oct 13, 2018
@chrisst chrisst deleted the generate-all-the-things branch October 15, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants