Specify the orverride import order #559
Conversation
chrisst
force-pushed
the
override-order
branch
from
fbb7fba to
b0e0657
Compare
There are some situations where the order that resources are overridden is critical. We have gotten lucky up until now that a strategy of "deepest first" was good enough. This will let us force the order when two or more resources depend on a specific ordering.
chrisst
force-pushed
the
override-order
branch
from
b0e0657 to
3868e3e
Compare
|
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
|
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
provider/property_override.rb
Outdated
| @@ -20,6 +20,16 @@ module Provider | |||
| class PropertyOverride < Api::Object | |||
| attr_reader :new_type | |||
|
|
|||
| # Ordering of imports can be important so this property can make the | |||
There was a problem hiding this comment.
I don't quite know what you mean by "ordering of imports".
There was a problem hiding this comment.
Oh I meant to say "ordering of overrides". Such that if 1 override is applied before a different one (in this case if Image is applied before SourceImage) then MM will break. This is because Source image is adding properties that the Image override depends on.
provider/property_override.rb
Outdated
| @@ -20,6 +20,16 @@ module Provider | |||
| class PropertyOverride < Api::Object | |||
| attr_reader :new_type | |||
|
|
|||
| # Ordering of imports can be important so this property can make the | |||
provider/property_override.rb
Outdated
| # with the lowest number getting imported first. | ||
| # The default is equal to the negative depth of the metric. This makes | ||
| # sure that more deeply nested fields happen first. | ||
| # eg: |
There was a problem hiding this comment.
nit: maybe "eg, for the compute.disk resource:"
|
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
There are some situations where the order that resources are overridden is
critical. We have gotten lucky up until now that a strategy of "deepest first"
was good enough. This will let us force the order when two or more resources
depend on a specific ordering.
[all]
[terraform]
[puppet]
[puppet-bigquery]
[puppet-compute]
[puppet-container]
[puppet-dns]
[puppet-logging]
[puppet-pubsub]
[puppet-resourcemanager]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-container]
[chef-dns]
[chef-logging]
[chef-spanner]
[chef-sql]
[chef-storage]
[ansible]