Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in resource name #650

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Fix typo in resource name #650

merged 2 commits into from
Oct 31, 2018

Conversation

danawillow
Copy link
Contributor

Same as hashicorp/terraform-provider-google#2365

[all]

[terraform]

Fix typo in resource name, same as TPG #2365

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

modular-magician commented Oct 30, 2018 •
edited by danawillow
Loading

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#65

@danawillow danawillow requested a review from chrisst October 30, 2018 22:00
@danawillow
Copy link
Contributor Author

@chrisst why are the downstreams trying to redo your website changes?

@chrisst
Copy link
Contributor

chrisst commented Oct 30, 2018

During the broken build madness and trying to get my PR's merged I think my website changes never actually got merged into tpg :(

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 1db21f1) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 62f0ca0) have been included in your existing downstream PRs.

danawillow and others added 2 commits October 31, 2018 16:11
@danawillow @modular-magician
Fix typo in resource name
22a2f71 
Same as hashicorp/terraform-provider-google#2365
@modular-magician
Update tracked submodules -> HEAD on Wed Oct 31 16:11:08 UTC 2018
aa7501b 
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 2b31012 into master Oct 31, 2018
@danawillow danawillow deleted the spanner-docs-typo branch October 31, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisst chrisst chrisst approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danawillow @modular-magician @chrisst @googlebot