Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST - DO NOT CHECK IN: force breakages in mmv1 #6609

Closed
wants to merge 5 commits into from

Conversation

ScottSuarez
Copy link
Contributor

testing for breaking change detector


@modular-magician
Copy link
Collaborator

modular-magician commented Sep 28, 2022

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 450 deletions(-))
Terraform Beta: Diff ( 4 files changed, 450 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2178
Passed tests 1938
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeInstance_soleTenantNodeAffinities

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@ScottSuarez
Copy link
Contributor Author

/gcbrun

10 similar comments
@ScottSuarez
Copy link
Contributor Author

/gcbrun

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician - !

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician - !

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2192
Passed tests 1947
Skipped tests: 240
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_update|TestAccCGCSnippet_eventarcWorkflowsExample

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2192
Passed tests 1949
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@ScottSuarez
Copy link
Contributor Author

/gcbrun

1 similar comment
@ScottSuarez
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician - !

Diff report

Terraform GA: Diff ( 4 files changed, 450 deletions(-))
Terraform Beta: Diff ( 4 files changed, 450 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician - !

Diff report

Terraform GA: Diff ( 4 files changed, 450 deletions(-))
Terraform Beta: Diff ( 4 files changed, 450 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2192
Passed tests 1950
Skipped tests: 240
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2192
Passed tests 1947
Skipped tests: 240
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeForwardingRule_update|TestAccComputeInstance_soleTenantNodeAffinities|TestAccBigQueryDataTable_bigtable|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@ScottSuarez ScottSuarez reopened this Oct 19, 2022
@ScottSuarez
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 450 deletions(-))
Terraform Beta: Diff ( 4 files changed, 450 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_storage_default_object_acl was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 54 insertions(+), 457 deletions(-))
Terraform Beta: Diff ( 5 files changed, 54 insertions(+), 457 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@ScottSuarez ScottSuarez added the override-breaking-change Allows a potential breaking change to be merged label Oct 19, 2022
@ScottSuarez ScottSuarez added override-breaking-change Allows a potential breaking change to be merged and removed override-breaking-change Allows a potential breaking change to be merged labels Oct 19, 2022
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_storage_default_object_acl was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 54 insertions(+), 457 deletions(-))
Terraform Beta: Diff ( 5 files changed, 54 insertions(+), 457 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@ScottSuarez ScottSuarez removed the override-breaking-change Allows a potential breaking change to be merged label Oct 19, 2022
@ScottSuarez
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_storage_default_object_acl was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 54 insertions(+), 457 deletions(-))
Terraform Beta: Diff ( 5 files changed, 54 insertions(+), 457 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2191
Passed tests 1952
Skipped tests: 239
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2191
Passed tests 1951
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

@ScottSuarez ScottSuarez added the override-breaking-change Allows a potential breaking change to be merged label Oct 26, 2022
@ScottSuarez ScottSuarez added override-breaking-change Allows a potential breaking change to be merged and removed override-breaking-change Allows a potential breaking change to be merged labels Oct 26, 2022
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_storage_default_object_acl was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 450 deletions(-))
Terraform Beta: Diff ( 4 files changed, 450 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@ScottSuarez ScottSuarez added override-breaking-change Allows a potential breaking change to be merged and removed override-breaking-change Allows a potential breaking change to be merged labels Oct 26, 2022
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2205
Passed tests 1965
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

meep-merp

@ScottSuarez ScottSuarez closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible override-breaking-change Allows a potential breaking change to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants