Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-plugin-sdk to 2.24.0 #6818

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Upgrade terraform-plugin-sdk to 2.24.0 #6818

merged 1 commit into from
Nov 30, 2022

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Nov 11, 2022

Fixed hashicorp/terraform-provider-google#12909

The test passed after upgrading sdk to 2.24.0. There is a bug fix in 2.23.0

sdk v2.24.0 causes more tests failing. To fix the tests, switch TestCase to using the ProviderFactories field instead of the deprecated Providers field.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@zli82016
Copy link
Member Author

make testacc TEST=./google TESTARGS='-run=TestAccCloudBuildTrigger_migration'

go generate ./...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccCloudBuildTrigger_migration -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN TestAccCloudBuildTrigger_migration
=== PAUSE TestAccCloudBuildTrigger_migration
=== CONT TestAccCloudBuildTrigger_migration
--- PASS: TestAccCloudBuildTrigger_migration (20.55s)
PASS
ok github.com/hashicorp/terraform-provider-google/google 23.549s

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 18 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 2 files changed, 18 insertions(+), 32 deletions(-))
TF Validator: Diff ( 2 files changed, 21 insertions(+), 20 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2247
Passed tests 1995
Skipped tests: 241
Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_totalSize|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_basic|TestAccContainerCluster_withResourceUsageExportConfig|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccProviderBasePath_setInvalidBasePath|TestAccProviderBasePath_setBasePath|TestAccSecurityScannerScanConfig_scanConfigBasicExample

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode:
TestAccContainerNodePool_basicWithClusterId[Error message] [Debug log]
TestAccContainerNodePool_autoscaling[Error message] [Debug log]
TestAccContainerNodePool_totalSize[Error message] [Debug log]
TestAccContainerNodePool_regionalAutoscaling[Error message] [Debug log]
TestAccContainerNodePool_basic[Error message] [Debug log]
TestAccContainerCluster_withResourceUsageExportConfig[Error message] [Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Error message] [Debug log]
TestAccComputeAutoscaler_autoscalerSingleInstanceExample[Error message] [Debug log]
TestAccProviderBasePath_setInvalidBasePath[Error message] [Debug log]
TestAccProviderBasePath_setBasePath[Error message] [Debug log]
TestAccSecurityScannerScanConfig_scanConfigBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 50 insertions(+), 46 deletions(-))
Terraform Beta: Diff ( 11 files changed, 68 insertions(+), 61 deletions(-))
TF Validator: Diff ( 2 files changed, 21 insertions(+), 20 deletions(-))
TF OiCS: Diff ( 3 files changed, 18 insertions(+), 15 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2254
Passed tests 2013
Skipped tests: 241
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

@shuyama1
Copy link
Member

/gcbrun

@@ -1,5 +1,5 @@
resource "google_compute_autoscaler" "<%= ctx[:primary_resource_id] %>" {
provider = google-beta
provider = google-beta.us-central1
Copy link
Member

@shuyama1 shuyama1 Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind explaining a bit about the change? I wonder why this error never occurs before.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 50 insertions(+), 46 deletions(-))
Terraform Beta: Diff ( 11 files changed, 68 insertions(+), 61 deletions(-))
TF Validator: Diff ( 2 files changed, 21 insertions(+), 20 deletions(-))
TF OiCS: Diff ( 3 files changed, 18 insertions(+), 15 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2264
Passed tests 2023
Skipped tests: 241
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 47 insertions(+), 49 deletions(-))
Terraform Beta: Diff ( 11 files changed, 62 insertions(+), 67 deletions(-))
TF Validator: Diff ( 2 files changed, 21 insertions(+), 20 deletions(-))
TF OiCS: Diff ( 3 files changed, 15 insertions(+), 18 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2267
Passed tests 2025
Skipped tests: 241
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeForwardingRule_update

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 43 insertions(+), 51 deletions(-))
Terraform Beta: Diff ( 11 files changed, 54 insertions(+), 71 deletions(-))
TF Validator: Diff ( 2 files changed, 21 insertions(+), 20 deletions(-))
TF OiCS: Diff ( 3 files changed, 11 insertions(+), 20 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2268
Passed tests 2023
Skipped tests: 243
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeAutoscaler_autoscalerSingleInstanceExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeAutoscaler_autoscalerSingleInstanceExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 34 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 11 files changed, 55 insertions(+), 56 deletions(-))
TF Validator: Diff ( 2 files changed, 21 insertions(+), 20 deletions(-))
TF OiCS: Diff ( 3 files changed, 15 insertions(+), 18 deletions(-))

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general! Only some nit picks.

Comment on lines 666 to 667
provider = google.compute_custom_endpoint
name = "address-test-%s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing is a bit off here. We use spaces rather than tabs in configuration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. Thanks.

Comment on lines -13 to -16
provider "google-beta" {
region = "us-central1"
zone = "us-central1-a"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also keep this in the test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally without the provider configuration with terraform apply and it worked. It looks like the provider configuration is optional for the users.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2268
Passed tests 2025
Skipped tests: 243
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 207 files changed, 1358 insertions(+), 1360 deletions(-))
Terraform Beta: Diff ( 240 files changed, 1633 insertions(+), 1631 deletions(-))
TF Validator: Diff ( 2 files changed, 24 insertions(+), 23 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

@zli82016
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 207 files changed, 1358 insertions(+), 1360 deletions(-))
Terraform Beta: Diff ( 240 files changed, 1633 insertions(+), 1631 deletions(-))
TF Validator: Diff ( 2 files changed, 24 insertions(+), 23 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 207 files changed, 1358 insertions(+), 1360 deletions(-))
Terraform Beta: Diff ( 240 files changed, 1633 insertions(+), 1631 deletions(-))
TF Validator: Diff ( 2 files changed, 24 insertions(+), 23 deletions(-))

@zli82016
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 207 files changed, 1358 insertions(+), 1360 deletions(-))
Terraform Beta: Diff ( 241 files changed, 1645 insertions(+), 1643 deletions(-))
TF Validator: Diff ( 2 files changed, 24 insertions(+), 23 deletions(-))

@modular-magician
Copy link
Collaborator

The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR
View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2294
Passed tests 1810
Skipped tests: 244
Failed tests: 240

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccAccessApprovalSettings|TestAccComputeSharedVpc_basic|TestAccKmsKeyRing_basic|TestAccNotebooksInstance_update|TestAccTags|TestAccComputeResourceUsageExportBucket|TestAccIdentityPlatformTenant_identityPlatformTenantUpdate|TestAccIdentityPlatformTenantOauthIdpConfig_identityPlatformTenantOauthIdpConfigUpdate|TestAccIdentityPlatformTenantInboundSamlConfig_identityPlatformTenantInboundSamlConfigUpdate|TestAccKmsCryptoKeyIamBinding|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccIdentityPlatformTenantDefaultSupportedIdpConfig_identityPlatformTenantDefaultSupportedIdpConfigUpdate|TestAccKmsCryptoKeyIamMember_withCondition|TestAccKmsCryptoKeyIamBinding_withCondition|TestAccKmsCryptoKeyIamPolicy|TestAccKmsCryptoKeyIamMember|TestAccServiceUsageConsumerQuotaOverride_consumerQuotaOverrideCustomIncorrectLimitFormat|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccServiceAccountIamPolicy_withCondition|TestAccServiceAccountIamPolicy_federatedIdentity|TestAccServiceAccountIamBinding_federatedIdentity|TestAccProject_labels|TestAccProject_create|TestAccProject_deleteDefaultNetwork|TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure|TestAccResourceGoogleProjectDefaultServiceAccountsDelete|TestAccResourceGoogleProjectDefaultServiceAccountsDisable|TestAccResourceGoogleProjectDefaultServiceAccountsBasic|TestAccProjectService_handleNotFound|TestAccProjectIamPolicy_withCondition|TestAccProjectIamPolicy_expandedAuditConfig|TestAccProjectIamPolicy_basicAuditConfig|TestAccProjectIamPolicy_expanded|TestAccProjectIamPolicy_emptyMembers|TestAccProjectIamPolicy_basic|TestAccServiceNetworkingConnection_create|TestAccProjectIamMember_withCondition|TestAccProjectIamMember_basic|TestAccProjectIamBinding_withCondition|TestAccProject_migrateParent|TestAccProjectIamBinding_noMembers|TestAccProjectIamBinding_update|TestAccProject_parentFolder|TestAccProjectIamBinding_multiple|TestAccProjectIamBinding_basic|TestAccProjectIamAuditConfig_updateNoExemptMembers|TestAccProjectIamAuditConfig_removeLastExemptMember|TestAccProjectIamAuditConfig_addFirstExemptMember|TestAccProjectIamAuditConfig_update|TestAccProjectIamAuditConfig_multiple|TestAccProjectIamAuditConfig_basic|TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege|TestAccDialogflowIntent_basic|TestAccDialogflowIntent_update|TestAccFirebaseWebApp_firebaseWebAppFull|TestAccDialogflowFulfillment_update|TestAccDialogflowEntityType_update|TestAccFirebaseHostingChannel_firebasehostingChannelUpdate|TestAccDialogflowAgent_update|TestAccDataprocCluster_withLifecycleConfigIdleDeleteTtl|TestAccDataprocCluster_withOptionalComponents|TestAccDataprocJob_Hadoop|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateUpdate|TestAccDataprocCluster_withServiceAcc|TestAccFirebaseWebApp_firebaseWebAppSkipDelete|TestAccFirebaseHostingSite_firebasehostingSiteUpdate|TestAccFirebaseAppleApp_update|TestAccFirebaseAndroidApp_update|TestAccDataFusionInstance_update|TestAccDataprocCluster_singleNodeCluster|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccDataprocCluster_withMetadataAndTags|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType|TestAccDataprocCluster_withAccelerators|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccDataprocCluster_withMetastoreConfig|TestAccEndpointsService_grpc|TestAccDataprocMetastoreService_updateAndImport|TestAccDataprocCluster_withConfigOverrides|TestAccComputeProjectMetadata_modify_2|TestAccComputeProjectMetadata_modify_1|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeProjectMetadata_basic|TestAccComputeProjectDefaultNetworkTier_modify|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeProjectDefaultNetworkTier_basic|TestAccCloudTasksQueue_MaxRetryDiffSuppress0s|TestAccCloudTasksQueue_update2Basic|TestAccCloudTasksQueue_update|TestAccCloudFunctions2Function_fullUpdate|TestAccComposerEnvironment_ComposerV2|TestAccBinaryAuthorizationPolicy_full|TestAccDataFusionInstanceEnterprise_update|TestAccBinaryAuthorizationPolicy_basic|TestAccBinaryAuthorizationPolicy_update|TestAccBigQueryJob_withLocation|TestAccBinaryAuthorizationPolicy_separateProject|TestAccBillingBudget_budgetFilterProjectsOrdering|TestAccAppEngineFlexibleAppVersion_update|TestAccApikeysKey_ServerKey|TestAccIapTunnelIamBindingGenerated|TestAccApikeysKey_MinimalKey|TestAccApikeysKey_AndroidKey|TestAccAppEngineApplication_withIAP|TestAccApikeysKey_IosKey|TestAccApikeysKey_BasicKey|TestAccAppEngineApplication_basic|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCaPoolIamBindingGenerated_withCondition|TestAccPrivatecaCaPoolIamMemberGenerated|TestAccPrivatecaCaPoolIamPolicyGenerated|TestAccPrivatecaCaPoolIamPolicyGenerated_withCondition|TestAccIapWebTypeComputeIamPolicyGenerated_withCondition|TestAccIapWebTypeComputeIamMemberGenerated_withCondition|TestAccPrivatecaCaPoolIamBindingGenerated|TestAccIapWebTypeComputeIamMemberGenerated|TestAccIapWebTypeComputeIamBindingGenerated_withCondition|TestAccIapWebTypeAppEngineIamPolicyGenerated_withCondition|TestAccIapWebTypeComputeIamBindingGenerated|TestAccIapWebTypeAppEngineIamMemberGenerated_withCondition|TestAccIapWebTypeAppEngineIamBindingGenerated_withCondition|TestAccIapWebTypeAppEngineIamPolicyGenerated|TestAccPrivatecaCaPoolIamMemberGenerated_withCondition|TestAccIapWebTypeComputeIamPolicyGenerated|TestAccIapWebTypeAppEngineIamBindingGenerated|TestAccIapWebIamMemberGenerated_withCondition|TestAccIapWebTypeAppEngineIamMemberGenerated|TestAccIapWebIamPolicyGenerated_withCondition|TestAccIapWebIamBindingGenerated_withCondition|TestAccIapWebIamBindingGenerated|TestAccIapWebIamPolicyGenerated|TestAccIapWebIamMemberGenerated|TestAccIapTunnelIamPolicyGenerated_withCondition|TestAccIapTunnelIamMemberGenerated|TestAccIapTunnelIamMemberGenerated_withCondition|TestAccIapTunnelIamBindingGenerated_withCondition|TestAccIapTunnelIamPolicyGenerated|TestAccAppEngineStandardAppVersion_update|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccComputeInstanceFromMachineImage_diffProject|TestAccServiceAccountIamMember_federatedIdentity|TestAccLoggingBucketConfigProject_cmekSettings|TestAccLoggingBucketConfigProject_basic|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccMonitoringDashboard_gridLayout|TestAccSqlDatabaseInstance_Timezone|TestAccLoggingBucketConfig_CreateBuckets_withCustomId|TestAccVertexAIEndpoint_vertexAiEndpointNetwork|TestAccComposerEnvironment_composerV2MasterAuthNetworksUpdate|TestAccComposerEnvironment_composerV2MasterAuthNetworks|TestAccIAMWorkforcePoolWorkforcePool_full|TestAccMonitoringMonitoredProject_BasicMonitoredProject|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccMonitoringMetricDescriptor_update|TestAccIapBrand_iapBrandExample|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccMonitoringDashboard_update|TestAccIapAppEngineServiceIamMemberGenerated|TestAccKmsKeyRingIamMember_withCondition|TestAccIAMWorkforcePoolWorkforcePoolProvider_saml|TestAccIAMWorkforcePoolWorkforcePoolProvider_oidc|TestAccIAMWorkforcePoolWorkforcePool_minimal|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccIapAppEngineServiceIamBindingGenerated|TestAccTPUNode_tpuNodeBUpdateTensorFlowVersion|TestAccPrivatecaCertificate_privatecaCertificateUpdate|TestAccServiceManagementServiceIamPolicyGenerated|TestAccPrivatecaCertificateAuthority_rootCaManageDesiredState|TestAccServiceManagementServiceIamMemberGenerated|TestAccServiceManagementServiceIamBindingGenerated|TestAccSqlDatabaseInstance_ActiveDirectory|TestAccServiceManagementServiceConsumersIamPolicyGenerated|TestAccIAMBetaWorkloadIdentityPool_minimal|TestAccStorageBucket_retentionPolicyLocked|TestAccDataSourceGoogleProject_basic|TestAccServiceManagementServiceConsumersIamMemberGenerated|TestAccIAM2DenyPolicy_iamDenyPolicyUpdate|TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccKmsCryptoKeyVersion_basic|TestAccKmsKeyRingIamMember|TestAccKmsKeyRingIamBinding_withCondition|TestAccResourceManagerLien_basic|TestAccKmsKeyRingIamBinding|TestAccLoggingProjectCmekSettings_basic|TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccServiceManagementServiceConsumersIamBindingGenerated|TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion|TestAccStorageBucket_update|TestAccKmsCryptoKeyVersion_patch|TestAccIAMBetaWorkloadIdentityPoolProvider_oidc|TestAccKmsCryptoKeyVersion_skipInitialVersion|TestAccStorageBucket_storageClass|TestAccIAMBetaWorkloadIdentityPool_full|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityUpdate|TestAccPrivatecaCaPool_updateCaOption|TestAccPrivatecaCaPool_privatecaCapoolEmptyPublishingOptions|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCaPool_privatecaCapoolUpdate|TestAccPrivatecaCaPoolIamMemberAllAuthenticatedUsersCasing|TestAccSqlDatabaseInstance_encryptionKey|TestAccIapClient_Datasource_basic|TestAccOrgPolicyPolicy_EnforcePolicy|TestAccCloudTasksQueueIamPolicyGenerated|TestAccCloudTasksQueueIamMemberGenerated|TestAccDataSourceDnsManagedZone_basic|TestAccCloudTasksQueueIamBindingGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamBindingGenerated|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccIAMBetaWorkloadIdentityPoolProvider_aws|TestAccDataSourcePrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccKmsCryptoKey_basic|TestAccKmsCryptoKey_importOnly|TestAccKmsCryptoKeyIamPolicy_withCondition|TestAccKmsKeyRingIamPolicy_withCondition|TestAccKmsKeyRingIamPolicy|TestAccKmsKeyRingImportJob_basic|TestAccKmsCryptoKey_template|TestAccKmsCryptoKey_destroyDuration|TestAccOsConfigOsPolicyAssignment_PercentOsPolicyAssignment|TestAccOsConfigOsPolicyAssignment_FixedOsPolicyAssignment|TestAccDataprocMetastoreServiceIamPolicyGenerated|TestAccDataprocMetastoreServiceIamBindingGenerated|TestAccDataprocMetastoreServiceIamMemberGenerated|TestAccDataprocMetastoreServiceDatasource_basic

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 34 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 11 files changed, 55 insertions(+), 56 deletions(-))
TF Validator: Diff ( 2 files changed, 21 insertions(+), 20 deletions(-))
TF OiCS: Diff ( 3 files changed, 2 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2302
Passed tests 2051
Skipped tests: 244
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccLoggingBucketConfigProject_cmekSettings|TestAccDataFusionInstance_dataFusionInstanceZoneExample|TestAccDataFusionInstance_dataFusionInstanceEventExample|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccDataFusionInstanceIamMemberGenerated|TestAccDataFusionInstanceIamPolicyGenerated|TestAccDataFusionInstanceIamBindingGenerated

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccDataFusionInstance_dataFusionInstanceZoneExample[Debug log]
TestAccDataFusionInstance_dataFusionInstanceEventExample[Debug log]
TestAccDataFusionInstance_dataFusionInstanceFullExample[Debug log]
TestAccDataFusionInstanceIamMemberGenerated[Debug log]
TestAccDataFusionInstanceIamPolicyGenerated[Debug log]
TestAccDataFusionInstanceIamBindingGenerated[Debug log]

All tests passed
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccCloudBuildTrigger_migration
3 participants