-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade terraform-plugin-sdk to 2.24.0 #6818
Conversation
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
make testacc TEST=./google TESTARGS='-run=TestAccCloudBuildTrigger_migration' go generate ./... |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 18 insertions(+), 32 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_totalSize|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_basic|TestAccContainerCluster_withResourceUsageExportConfig|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccProviderBasePath_setInvalidBasePath|TestAccProviderBasePath_setBasePath|TestAccSecurityScannerScanConfig_scanConfigBasicExample |
Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 50 insertions(+), 46 deletions(-)) |
Tests analyticsTotal tests: All tests passed in REPLAYING mode |
/gcbrun |
@@ -1,5 +1,5 @@ | |||
resource "google_compute_autoscaler" "<%= ctx[:primary_resource_id] %>" { | |||
provider = google-beta | |||
provider = google-beta.us-central1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind explaining a bit about the change? I wonder why this error never occurs before.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 50 insertions(+), 46 deletions(-)) |
Tests analyticsTotal tests: All tests passed in REPLAYING mode |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 47 insertions(+), 49 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeForwardingRule_update |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 43 insertions(+), 51 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccComputeAutoscaler_autoscalerSingleInstanceExample |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 34 insertions(+), 36 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general! Only some nit picks.
provider = google.compute_custom_endpoint | ||
name = "address-test-%s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing is a bit off here. We use spaces rather than tabs in configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. Thanks.
provider "google-beta" { | ||
region = "us-central1" | ||
zone = "us-central1-a" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also keep this in the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally without the provider configuration with terraform apply
and it worked. It looks like the provider configuration is optional for the users.
Tests analyticsTotal tests: All tests passed in REPLAYING mode |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 207 files changed, 1358 insertions(+), 1360 deletions(-)) |
Tests analyticsTotal tests: Errors occurred during REPLAYING mode. Please fix them to complete your PR |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 207 files changed, 1358 insertions(+), 1360 deletions(-)) |
Tests analyticsTotal tests: Errors occurred during REPLAYING mode. Please fix them to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 207 files changed, 1358 insertions(+), 1360 deletions(-)) |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 207 files changed, 1358 insertions(+), 1360 deletions(-)) |
The provider crashed while running the VCR tests in REPLAYING mode |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccAccessApprovalSettings|TestAccComputeSharedVpc_basic|TestAccKmsKeyRing_basic|TestAccNotebooksInstance_update|TestAccTags|TestAccComputeResourceUsageExportBucket|TestAccIdentityPlatformTenant_identityPlatformTenantUpdate|TestAccIdentityPlatformTenantOauthIdpConfig_identityPlatformTenantOauthIdpConfigUpdate|TestAccIdentityPlatformTenantInboundSamlConfig_identityPlatformTenantInboundSamlConfigUpdate|TestAccKmsCryptoKeyIamBinding|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccIdentityPlatformTenantDefaultSupportedIdpConfig_identityPlatformTenantDefaultSupportedIdpConfigUpdate|TestAccKmsCryptoKeyIamMember_withCondition|TestAccKmsCryptoKeyIamBinding_withCondition|TestAccKmsCryptoKeyIamPolicy|TestAccKmsCryptoKeyIamMember|TestAccServiceUsageConsumerQuotaOverride_consumerQuotaOverrideCustomIncorrectLimitFormat|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccServiceAccountIamPolicy_withCondition|TestAccServiceAccountIamPolicy_federatedIdentity|TestAccServiceAccountIamBinding_federatedIdentity|TestAccProject_labels|TestAccProject_create|TestAccProject_deleteDefaultNetwork|TestAccResourceGoogleProjectDefaultServiceAccountsDeleteRevertIgnoreFailure|TestAccResourceGoogleProjectDefaultServiceAccountsDelete|TestAccResourceGoogleProjectDefaultServiceAccountsDisable|TestAccResourceGoogleProjectDefaultServiceAccountsBasic|TestAccProjectService_handleNotFound|TestAccProjectIamPolicy_withCondition|TestAccProjectIamPolicy_expandedAuditConfig|TestAccProjectIamPolicy_basicAuditConfig|TestAccProjectIamPolicy_expanded|TestAccProjectIamPolicy_emptyMembers|TestAccProjectIamPolicy_basic|TestAccServiceNetworkingConnection_create|TestAccProjectIamMember_withCondition|TestAccProjectIamMember_basic|TestAccProjectIamBinding_withCondition|TestAccProject_migrateParent|TestAccProjectIamBinding_noMembers|TestAccProjectIamBinding_update|TestAccProject_parentFolder|TestAccProjectIamBinding_multiple|TestAccProjectIamBinding_basic|TestAccProjectIamAuditConfig_updateNoExemptMembers|TestAccProjectIamAuditConfig_removeLastExemptMember|TestAccProjectIamAuditConfig_addFirstExemptMember|TestAccProjectIamAuditConfig_update|TestAccProjectIamAuditConfig_multiple|TestAccProjectIamAuditConfig_basic|TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege|TestAccDialogflowIntent_basic|TestAccDialogflowIntent_update|TestAccFirebaseWebApp_firebaseWebAppFull|TestAccDialogflowFulfillment_update|TestAccDialogflowEntityType_update|TestAccFirebaseHostingChannel_firebasehostingChannelUpdate|TestAccDialogflowAgent_update|TestAccDataprocCluster_withLifecycleConfigIdleDeleteTtl|TestAccDataprocCluster_withOptionalComponents|TestAccDataprocJob_Hadoop|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateUpdate|TestAccDataprocCluster_withServiceAcc|TestAccFirebaseWebApp_firebaseWebAppSkipDelete|TestAccFirebaseHostingSite_firebasehostingSiteUpdate|TestAccFirebaseAppleApp_update|TestAccFirebaseAndroidApp_update|TestAccDataFusionInstance_update|TestAccDataprocCluster_singleNodeCluster|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccDataprocCluster_withMetadataAndTags|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType|TestAccDataprocCluster_withAccelerators|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccDataprocCluster_withMetastoreConfig|TestAccEndpointsService_grpc|TestAccDataprocMetastoreService_updateAndImport|TestAccDataprocCluster_withConfigOverrides|TestAccComputeProjectMetadata_modify_2|TestAccComputeProjectMetadata_modify_1|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeProjectMetadata_basic|TestAccComputeProjectDefaultNetworkTier_modify|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeProjectDefaultNetworkTier_basic|TestAccCloudTasksQueue_MaxRetryDiffSuppress0s|TestAccCloudTasksQueue_update2Basic|TestAccCloudTasksQueue_update|TestAccCloudFunctions2Function_fullUpdate|TestAccComposerEnvironment_ComposerV2|TestAccBinaryAuthorizationPolicy_full|TestAccDataFusionInstanceEnterprise_update|TestAccBinaryAuthorizationPolicy_basic|TestAccBinaryAuthorizationPolicy_update|TestAccBigQueryJob_withLocation|TestAccBinaryAuthorizationPolicy_separateProject|TestAccBillingBudget_budgetFilterProjectsOrdering|TestAccAppEngineFlexibleAppVersion_update|TestAccApikeysKey_ServerKey|TestAccIapTunnelIamBindingGenerated|TestAccApikeysKey_MinimalKey|TestAccApikeysKey_AndroidKey|TestAccAppEngineApplication_withIAP|TestAccApikeysKey_IosKey|TestAccApikeysKey_BasicKey|TestAccAppEngineApplication_basic|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCaPoolIamBindingGenerated_withCondition|TestAccPrivatecaCaPoolIamMemberGenerated|TestAccPrivatecaCaPoolIamPolicyGenerated|TestAccPrivatecaCaPoolIamPolicyGenerated_withCondition|TestAccIapWebTypeComputeIamPolicyGenerated_withCondition|TestAccIapWebTypeComputeIamMemberGenerated_withCondition|TestAccPrivatecaCaPoolIamBindingGenerated|TestAccIapWebTypeComputeIamMemberGenerated|TestAccIapWebTypeComputeIamBindingGenerated_withCondition|TestAccIapWebTypeAppEngineIamPolicyGenerated_withCondition|TestAccIapWebTypeComputeIamBindingGenerated|TestAccIapWebTypeAppEngineIamMemberGenerated_withCondition|TestAccIapWebTypeAppEngineIamBindingGenerated_withCondition|TestAccIapWebTypeAppEngineIamPolicyGenerated|TestAccPrivatecaCaPoolIamMemberGenerated_withCondition|TestAccIapWebTypeComputeIamPolicyGenerated|TestAccIapWebTypeAppEngineIamBindingGenerated|TestAccIapWebIamMemberGenerated_withCondition|TestAccIapWebTypeAppEngineIamMemberGenerated|TestAccIapWebIamPolicyGenerated_withCondition|TestAccIapWebIamBindingGenerated_withCondition|TestAccIapWebIamBindingGenerated|TestAccIapWebIamPolicyGenerated|TestAccIapWebIamMemberGenerated|TestAccIapTunnelIamPolicyGenerated_withCondition|TestAccIapTunnelIamMemberGenerated|TestAccIapTunnelIamMemberGenerated_withCondition|TestAccIapTunnelIamBindingGenerated_withCondition|TestAccIapTunnelIamPolicyGenerated|TestAccAppEngineStandardAppVersion_update|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccComputeInstanceFromMachineImage_diffProject|TestAccServiceAccountIamMember_federatedIdentity|TestAccLoggingBucketConfigProject_cmekSettings|TestAccLoggingBucketConfigProject_basic|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccMonitoringDashboard_gridLayout|TestAccSqlDatabaseInstance_Timezone|TestAccLoggingBucketConfig_CreateBuckets_withCustomId|TestAccVertexAIEndpoint_vertexAiEndpointNetwork|TestAccComposerEnvironment_composerV2MasterAuthNetworksUpdate|TestAccComposerEnvironment_composerV2MasterAuthNetworks|TestAccIAMWorkforcePoolWorkforcePool_full|TestAccMonitoringMonitoredProject_BasicMonitoredProject|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccMonitoringMetricDescriptor_update|TestAccIapBrand_iapBrandExample|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccMonitoringDashboard_update|TestAccIapAppEngineServiceIamMemberGenerated|TestAccKmsKeyRingIamMember_withCondition|TestAccIAMWorkforcePoolWorkforcePoolProvider_saml|TestAccIAMWorkforcePoolWorkforcePoolProvider_oidc|TestAccIAMWorkforcePoolWorkforcePool_minimal|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccIapAppEngineServiceIamBindingGenerated|TestAccTPUNode_tpuNodeBUpdateTensorFlowVersion|TestAccPrivatecaCertificate_privatecaCertificateUpdate|TestAccServiceManagementServiceIamPolicyGenerated|TestAccPrivatecaCertificateAuthority_rootCaManageDesiredState|TestAccServiceManagementServiceIamMemberGenerated|TestAccServiceManagementServiceIamBindingGenerated|TestAccSqlDatabaseInstance_ActiveDirectory|TestAccServiceManagementServiceConsumersIamPolicyGenerated|TestAccIAMBetaWorkloadIdentityPool_minimal|TestAccStorageBucket_retentionPolicyLocked|TestAccDataSourceGoogleProject_basic|TestAccServiceManagementServiceConsumersIamMemberGenerated|TestAccIAM2DenyPolicy_iamDenyPolicyUpdate|TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccKmsCryptoKeyVersion_basic|TestAccKmsKeyRingIamMember|TestAccKmsKeyRingIamBinding_withCondition|TestAccResourceManagerLien_basic|TestAccKmsKeyRingIamBinding|TestAccLoggingProjectCmekSettings_basic|TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccServiceManagementServiceConsumersIamBindingGenerated|TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion|TestAccStorageBucket_update|TestAccKmsCryptoKeyVersion_patch|TestAccIAMBetaWorkloadIdentityPoolProvider_oidc|TestAccKmsCryptoKeyVersion_skipInitialVersion|TestAccStorageBucket_storageClass|TestAccIAMBetaWorkloadIdentityPool_full|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityUpdate|TestAccPrivatecaCaPool_updateCaOption|TestAccPrivatecaCaPool_privatecaCapoolEmptyPublishingOptions|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCaPool_privatecaCapoolUpdate|TestAccPrivatecaCaPoolIamMemberAllAuthenticatedUsersCasing|TestAccSqlDatabaseInstance_encryptionKey|TestAccIapClient_Datasource_basic|TestAccOrgPolicyPolicy_EnforcePolicy|TestAccCloudTasksQueueIamPolicyGenerated|TestAccCloudTasksQueueIamMemberGenerated|TestAccDataSourceDnsManagedZone_basic|TestAccCloudTasksQueueIamBindingGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamBindingGenerated|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccIAMBetaWorkloadIdentityPoolProvider_aws|TestAccDataSourcePrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccKmsCryptoKey_basic|TestAccKmsCryptoKey_importOnly|TestAccKmsCryptoKeyIamPolicy_withCondition|TestAccKmsKeyRingIamPolicy_withCondition|TestAccKmsKeyRingIamPolicy|TestAccKmsKeyRingImportJob_basic|TestAccKmsCryptoKey_template|TestAccKmsCryptoKey_destroyDuration|TestAccOsConfigOsPolicyAssignment_PercentOsPolicyAssignment|TestAccOsConfigOsPolicyAssignment_FixedOsPolicyAssignment|TestAccDataprocMetastoreServiceIamPolicyGenerated|TestAccDataprocMetastoreServiceIamBindingGenerated|TestAccDataprocMetastoreServiceIamMemberGenerated|TestAccDataprocMetastoreServiceDatasource_basic |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 34 insertions(+), 36 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccLoggingBucketConfigProject_cmekSettings|TestAccDataFusionInstance_dataFusionInstanceZoneExample|TestAccDataFusionInstance_dataFusionInstanceEventExample|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccDataFusionInstanceIamMemberGenerated|TestAccDataFusionInstanceIamPolicyGenerated|TestAccDataFusionInstanceIamBindingGenerated |
Tests passed during RECORDING mode: All tests passed |
Fixed hashicorp/terraform-provider-google#12909
The test passed after upgrading sdk to 2.24.0. There is a bug fix in 2.23.0
sdk v2.24.0 causes more tests failing. To fix the tests, switch TestCase to using the
ProviderFactories
field instead of the deprecatedProviders
field.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)