Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency charset-normalizer to v3 #1193

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Oct 20, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
charset-normalizer ==2.1.1 -> ==3.0.1 age adoption passing confidence

Release Notes

Ousret/charset_normalizer

v3.0.1

Compare Source

Fixed
  • Multi-bytes cutter/chunk generator did not always cut correctly (PR #​233)
Changed
  • Speedup provided by mypy/c 0.990 on Python >= 3.7

v3.0.0

Compare Source

Added
  • Extend the capability of explain=True when cp_isolation contains at most two entries (min one), will log in details of the Mess-detector results
  • Support for alternative language frequency set in charset_normalizer.assets.FREQUENCIES
  • Add parameter language_threshold in from_bytes, from_path and from_fp to adjust the minimum expected coherence ratio
  • normalizer --version now specify if current version provide extra speedup (meaning mypyc compilation whl)
Changed
  • Build with static metadata using 'build' frontend
  • Make the language detection stricter
  • Optional: Module md.py can be compiled using Mypyc to provide an extra speedup up to 4x faster than v2.1
Fixed
  • CLI with opt --normalize fail when using full path for files
  • TooManyAccentuatedPlugin induce false positive on the mess detection when too few alpha character have been fed to it
  • Sphinx warnings when generating the documentation
Removed
  • Coherence detector no longer return 'Simple English' instead return 'English'
  • Coherence detector no longer return 'Classical Chinese' instead return 'Chinese'
  • Breaking: Method first() and best() from CharsetMatch
  • UTF-7 will no longer appear as "detected" without a recognized SIG/mark (is unreliable/conflict with ASCII)
  • Breaking: Class aliases CharsetDetector, CharsetDoctor, CharsetNormalizerMatch and CharsetNormalizerMatches
  • Breaking: Top-level function normalize
  • Breaking: Properties chaos_secondary_pass, coherence_non_latin and w_counter from CharsetMatch
  • Support for the backport unicodedata2

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team as a code owner October 20, 2022 20:30
@forking-renovate forking-renovate bot added dependencies Pull requests that update a dependency file lang: python Issues specific to Python. labels Oct 20, 2022
@bourgeoisor
Copy link
Member

The conflict is caused by:
    The user requested charset-normalizer==3.0.0
    requests 2.28.1 depends on charset-normalizer<3 and >=2

@mathieu-benoit mathieu-benoit added the status: blocked Resolving the issue is dependent on other work. label Oct 21, 2022
@bourgeoisor
Copy link
Member

requests merged this: psf/requests#6261
Should make it for the next version.

@NimJay NimJay added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 21, 2022
@arbrown
Copy link
Contributor

arbrown commented Oct 27, 2022

Waiting on a new version of requests to be released with the fix @bourgeoisor linked above.

https://pypi.org/project/requests/

@renovate-bot renovate-bot force-pushed the renovate/charset-normalizer-3.x branch 3 times, most recently from 1e16c1c to d846291 Compare November 8, 2022 12:31
@renovate-bot renovate-bot force-pushed the renovate/charset-normalizer-3.x branch from d846291 to dc5afa3 Compare November 17, 2022 17:13
@NimJay NimJay added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Nov 22, 2022
@renovate-bot renovate-bot force-pushed the renovate/charset-normalizer-3.x branch from dc5afa3 to fd03cfa Compare November 25, 2022 09:40
@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Nov 28, 2022

Still getting the same issue:

ERROR: Cannot install -r requirements.txt (line 56) and charset-normalizer==3.0.1 because these package versions have conflicting dependencies.
#9 8.556 
#9 8.556 The conflict is caused by:
#9 8.556     The user requested charset-normalizer==3.0.1
#9 8.556     requests 2.28.1 depends on charset-normalizer<3 and >=2

This will be fixed in requests 2.29.0 as per psf/requests#6288 (comment).

@renovate-bot renovate-bot force-pushed the renovate/charset-normalizer-3.x branch from 95a922f to a12eb0d Compare November 28, 2022 17:59
@renovate-bot renovate-bot force-pushed the renovate/charset-normalizer-3.x branch 4 times, most recently from 7fd3d33 to 9a4c3d2 Compare December 13, 2022 01:18
@NimJay NimJay added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 13, 2022
@minherz minherz added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 13, 2022
minherz added a commit that referenced this pull request Dec 13, 2022
@minherz
Copy link
Contributor

minherz commented Dec 14, 2022

This PR cannot be merged because the latest version of the requests (2.81.1) supports only charset-normalizer < 3. The renovate bot does not respect the constraint.
The version can be upgraded with the next version of requests which lifts the constraint.

minherz added a commit that referenced this pull request Dec 14, 2022
minherz added a commit that referenced this pull request Dec 14, 2022
* chore(deps): manual upgrade of dependencies

accumulated upgrades from renovate PRs #997, #1094, #1095, #1193, #1379, #1384, #1387, #1388, #1389,

* chore(deps): fix dependencies

due to requests constraint the charset-normalizer is rolled back to
lates of major version 2 (2.1.1).
add importlib-metadata dependency.
update opentelemetry-* to the version supported by 1.15.0 of the SDK.
rollback to docker 3.10 for email & recommendation cause profiler package
does not support python 3.11
regenerate email and recommendation svs protobuf

* chore(deps): adding changes from #1402 and #1403
@renovate-bot renovate-bot force-pushed the renovate/charset-normalizer-3.x branch from 9a4c3d2 to 0ca334e Compare December 14, 2022 20:18
@bourgeoisor
Copy link
Member

Speaking of new release, I just learned that the new release of request should be either this month or the next: psf/requests#6306

@bourgeoisor
Copy link
Member

There is now a new version of requests which fixes the above issue: https://github.com/psf/requests/releases

@renovate-bot renovate-bot force-pushed the renovate/charset-normalizer-3.x branch from 0ca334e to 14278ae Compare January 19, 2023 20:29
@renovate-bot renovate-bot requested a review from a team as a code owner January 19, 2023 20:29
@renovate-bot renovate-bot force-pushed the renovate/charset-normalizer-3.x branch 2 times, most recently from c2fa05a to 1d2a593 Compare February 23, 2023 04:40
@renovate-bot renovate-bot force-pushed the renovate/charset-normalizer-3.x branch from 1d2a593 to 1314e78 Compare February 23, 2023 15:22
@bourgeoisor bourgeoisor removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Feb 23, 2023
@bourgeoisor bourgeoisor merged commit 423da34 into GoogleCloudPlatform:main Feb 23, 2023
@renovate-bot renovate-bot deleted the renovate/charset-normalizer-3.x branch February 23, 2023 18:28
mrcrgl pushed a commit to fiberfjord/microservices-demo that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lang: python Issues specific to Python.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants