Fix kubernetes-manifests/kustomization.yaml empty components issue #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
NimJay
changed the title
NimJay
changed the title
NimJay
changed the title
NimJay
reviewed
Jan 18, 2023
| if [[ $file_to_copy == "./kubernetes-manifests/kustomization.yaml" ]]; then | ||
| continue | ||
| fi | ||
|
|
There was a problem hiding this comment.
I just added this change into hack/make-release-artifacts.sh.
Context:
- Today, when a new release of Online Boutique is created
kubernetes-manifests/kustomization.yamlis copied over tokustomize/base/kustomization.yaml. - This should not be the case since the two files are meant to look different.
- For instance,
kustomize/base/kustomization.yamlshould not include:
# components:
or
# - loadgenerator.yaml # During development, the loadgenerator module inside skaffold.yaml will be used.
NimJay
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
@phamquiluan sorry for the delayed review.
And thank you for:
- creating a clear GitHub issue
- creating a pull-request to fix the issue
I have not reproduced the issue on my end, but I trust that your fix worked for you.
Plus, the fix won't negatively impact anyone else's user experience.
Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1435.