Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename deprecated script names #1574

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

tpryan
Copy link
Collaborator

@tpryan tpryan commented Mar 2, 2023

Background

DeployStack is deprecating some names of its scripts. They were redundant. (preinitscript.sh) The new name (preinit.sh) already works and works the same as what it is replacing.

@tpryan tpryan requested a review from a team as a code owner March 2, 2023 06:06
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

🚲 PR staged at http://34.68.186.207

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "script" in "preinitscript.sh" does feel redundant.
Thanks for addressing this. Approved. Merging.

@NimJay NimJay merged commit e87463f into main Mar 2, 2023
@NimJay NimJay deleted the deploystack-config-change branch March 2, 2023 14:46
mrcrgl pushed a commit to fiberfjord/microservices-demo that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants