cartservice - .NET 8
#2102
Merged
cartservice - .NET 8
#2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieu-benoit
requested review from
yoshi-approver and
a team
as code owners
Ready for your review, thanks! |
NimJay
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
All checks are passing. The staging URL works. Changes look good. Approved.
Thanks so much for volunteering your .NET expertise and for this PR, @mathieu-benoit! 😊
| COPY . . | ||
| RUN dotnet publish cartservice.csproj -p:PublishSingleFile=true -r linux-musl-x64 --self-contained true -p:PublishTrimmed=True -p:TrimMode=Link -c release -o /cartservice --no-restore | ||
| RUN dotnet publish cartservice.csproj \ |
There was a problem hiding this comment.
Praise: Thanks for tidying up this RUN dotnet publish cartservice.csproj command!
|
|
||
| WORKDIR /app | ||
| COPY --from=builder /cartservice . | ||
| EXPOSE 7070 | ||
| ENV DOTNET_EnableDiagnostics=0 \ | ||
| ASPNETCORE_URLS=http://*:7070 | ||
| ASPNETCORE_HTTP_PORTS=7070 |
There was a problem hiding this comment.
Praise: Thanks for taking care of the little details like ASPNETCORE_HTTP_PORTS and TrimMode=Full.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like it was done here and here with .NET 7. .NET 8 in RC1 is out, this is anticipating the GA launch planned in November 2023 and have Online Boutique ready for this.
Also:
ASPNETCORE_HTTP_PORTSinstead ofASPNETCORE_HTTP_URLS-p:TrimMode=Fullinstead ofLink, now workingStackExchange.Redisrequired for IPv6 in the past. SeeMicrosoft.Extensions.Caching.StackExchangeRedisnot working with IPv6 because using an old version ofStackExchange.Redisdotnet/aspnetcore#45424.src/cartservice/src/Dockerfile.debug- this image is not built/published per se, it's more aDockerfileif someone wants to runcartserviceinDebugmode locally, etc.JFYI: before implementing this here, I also tested this .NET 8 update on a sample app.