Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: renovate otel grouping and pip-compile fixes #2138

Merged
merged 6 commits into from
Sep 29, 2023
Merged

Conversation

muncus
Copy link
Contributor

@muncus muncus commented Sep 25, 2023

Moving to json5 allows comments in this config file.

OTel dependency groups avoid PRs with broken tests because the OTel packages
have tight version coupling.

Also updates the way language labels are added, as suggested by renovate's
"config migrator"

@github-actions
Copy link

🚲 PR staged at http://34.173.233.92

],
"pip-compile": {
"enabled": true,
"fileMatch": ["(^|/)requirements\\.in$"]
Copy link
Collaborator

@NimJay NimJay Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Sorry, I realize this pull-request is still in draft, but in case I forget to ask later...
Is the omission of the following intentional?

    "lockFileMaintenance": {
      "enabled": true
    }

Relevant pull-request: #772

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lock file maintenance is enabled by default for this manager:
https://docs.renovatebot.com/modules/manager/pip-compile/#default-config

so i don't think we need it, but if we do I'm happy to add it in a followup PR.

(and questions are always welcome, even on drafts!)

Copy link
Collaborator

@NimJay NimJay Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it! Thanks so much (for digging up and sharing that "Default config" section).
Looks good.

@github-actions
Copy link

🚲 PR staged at http://34.173.233.92

@muncus muncus marked this pull request as ready for review September 27, 2023 17:03
@muncus muncus requested review from yoshi-approver and a team as code owners September 27, 2023 17:03
.github/renovate.json5 Outdated Show resolved Hide resolved
@github-actions
Copy link

🚲 PR staged at http://34.173.233.92

1 similar comment
@github-actions
Copy link

🚲 PR staged at http://34.173.233.92

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks for addressing my concerns.
But more importantly, thank you for working on these Renovate improvements, @muncus!
Merging.

@NimJay NimJay merged commit 3a6a0e8 into main Sep 29, 2023
@NimJay NimJay deleted the renovateconfig branch September 29, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants