-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: renovate otel grouping and pip-compile fixes #2138
Conversation
language label update was taken from renovate's own config migration.
🚲 PR staged at http://34.173.233.92 |
], | ||
"pip-compile": { | ||
"enabled": true, | ||
"fileMatch": ["(^|/)requirements\\.in$"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Sorry, I realize this pull-request is still in draft, but in case I forget to ask later...
Is the omission of the following intentional?
"lockFileMaintenance": {
"enabled": true
}
Relevant pull-request: #772
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lock file maintenance is enabled by default for this manager:
https://docs.renovatebot.com/modules/manager/pip-compile/#default-config
so i don't think we need it, but if we do I'm happy to add it in a followup PR.
(and questions are always welcome, even on drafts!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, got it! Thanks so much (for digging up and sharing that "Default config" section).
Looks good.
🚲 PR staged at http://34.173.233.92 |
Co-authored-by: Nim Jayawardena <nimjay@google.com>
🚲 PR staged at http://34.173.233.92 |
1 similar comment
🚲 PR staged at http://34.173.233.92 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Thanks for addressing my concerns.
But more importantly, thank you for working on these Renovate improvements, @muncus!
Merging.
Moving to json5 allows comments in this config file.
OTel dependency groups avoid PRs with broken tests because the OTel packages
have tight version coupling.
Also updates the way language labels are added, as suggested by renovate's
"config migrator"