Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix credit card validation error #2467

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Fix credit card validation error #2467

merged 1 commit into from
Apr 8, 2024

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Apr 8, 2024 •
edited
Loading

Background

  • Current, checking out produces the following error:
Screenshot 2024-04-08 at 2 04 03 PM

Change Summary

  • Remove dashes ("-"s) in credit card during submission.

Testing Procedure

  • We just need to test that checking out (via the staging URL) works.

@NimJay NimJay mentioned this pull request Apr 8, 2024
Merged
@NimJay NimJay marked this pull request as ready for review April 8, 2024 21:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

🚲 PR staged at http://34.31.229.209

@NimJay NimJay requested review from yoshi-approver and a team as code owners April 8, 2024 21:10
bourgeoisor
bourgeoisor approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staging deployment works as intended. Looks good to me!

@NimJay NimJay merged commit 84f0ad9 into main Apr 8, 2024
10 checks passed
@NimJay NimJay deleted the nimjay-cc-validation branch April 8, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bourgeoisor bourgeoisor bourgeoisor approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NimJay @bourgeoisor