fix: change dataproc success message and test (#269)

* Added create cluster sample for Cloud Dataproc * Modify test and slight change to Dataproc success message * Changed region tag to include 'dataproc' * changed dataproc imports to explicit v1
GoogleCloudPlatform · Nov 18, 2019 · 0170f9e · 0170f9e
1 parent 83b858a
commit 0170f9e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/dataproc/createCluster.js b/dataproc/createCluster.js
@@ -15,8 +15,8 @@
 // Code for creating a Cloud Dataproc cluster with the Node.js Client Library
 
 function main(projectId, region, clusterName) {
- // [START create_cluster]
- const dataproc = require('@google-cloud/dataproc');
+ // [START dataproc_create_cluster]
+ const dataproc = require('@google-cloud/dataproc').v1;
 
  // Create a client with the endpoint set to the desired cluster region
  const client = new dataproc.v1.ClusterControllerClient({
@@ -29,7 +29,7 @@ function main(projectId, region, clusterName) {
  // region = 'YOUR_CLUSTER_REGION'
  // cluster_name = 'YOUR_CLUSTER_NAME'
 
- // Create your cluster config
+ // Create the cluster config
  const request = {
  projectId: projectId,
  region: region,
@@ -48,13 +48,13 @@ function main(projectId, region, clusterName) {
  },
  };
 
- // Create our cluster
+ // Create the cluster
  const [operation] = await client.createCluster(request);
  const [response] = await operation.promise();
 
- // Output the response
- console.log(response);
- // [END create_cluster]
+ // Output a success message
+ console.log(`Cluster created successfully: ${response.clusterName}`);
+ // [END dataproc_create_cluster]
  }
 
  createCluster();

diff --git a/dataproc/package.json b/dataproc/package.json
@@ -14,7 +14,9 @@
  "test": "mocha system-test --timeout 600000"
  },
  "dependencies": {
- "@google-cloud/dataproc": "^1.4.2"
+ "@google-cloud/dataproc": "^1.4.2",
+ "uuid": "^3.3.3",
+ "yargs": "^14.0.0"
  },
  "devDependencies": {
  "chai": "^4.2.0",

diff --git a/dataproc/system-test/createCluster.test.js b/dataproc/system-test/createCluster.test.js
@@ -21,7 +21,7 @@ const uuid = require('uuid');
 const region = 'us-central1';
 const clusterName = `test-${uuid()}`;
 
-const dataproc = require('@google-cloud/dataproc');
+const dataproc = require('@google-cloud/dataproc').v1;
 const client = new dataproc.v1.ClusterControllerClient({
  apiEndpoint: `${region}-dataproc.googleapis.com`,
 });
@@ -35,7 +35,7 @@ describe('create a dataproc cluster', () => {
  const stdout = execSync(
  `node createCluster.js "${projectId}" "${region}" "${clusterName}"`
  );
- assert.match(stdout, /clusterUuid/);
+ assert.match(stdout, new RegExp(`${clusterName}`));
  });
 
  after(async () => {