Skip to content

Commit

Permalink
Use valid format for App Engine version string (#663)
Browse files Browse the repository at this point in the history
argument --version/-v: Bad value
[doc-sample-appengine/hello-world/standard-standard]: May only contain
lowercase letters, digits, and hyphens. Must begin and end with a
letter or digit. Must not exceed 63 characters.
  • Loading branch information
fhinkel authored Jun 15, 2018
1 parent 6d2e1aa commit 12a666d
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 37 deletions.
6 changes: 0 additions & 6 deletions .kokoro/appengine/test-deployment/hello-world-flex.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@
env_vars: {
key: "PROJECT"
value: "appengine/hello-world/flexible"
}

# flexible or standard
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "flexible"
}
6 changes: 0 additions & 6 deletions .kokoro/appengine/test-deployment/hello-world-standard.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@
env_vars: {
key: "PROJECT"
value: "appengine/hello-world/standard"
}

# flexible or standard
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "standard"
}
6 changes: 0 additions & 6 deletions .kokoro/appengine/test-deployment/metadata-flex.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@
env_vars: {
key: "PROJECT"
value: "appengine/metadata/flexible"
}

# flexible or standard
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "flexible"
}
6 changes: 0 additions & 6 deletions .kokoro/appengine/test-deployment/metadata-standard.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@
env_vars: {
key: "PROJECT"
value: "appengine/metadata/standard"
}

# flexible or standard
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "standard"
}
6 changes: 0 additions & 6 deletions .kokoro/appengine/test-deployment/storage-flex.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@
env_vars: {
key: "PROJECT"
value: "appengine/storage/flexible"
}

# flexible or standard
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "flexible"
}
6 changes: 0 additions & 6 deletions .kokoro/appengine/test-deployment/storage-standard.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,4 @@
env_vars: {
key: "PROJECT"
value: "appengine/storage/standard"
}

# flexible or standard
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "standard"
}
2 changes: 1 addition & 1 deletion .kokoro/build-with-appengine.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ gcloud auth activate-service-account --key-file "$GOOGLE_APPLICATION_CREDENTIALS
gcloud config set project $GCLOUD_PROJECT

export NODE_ENV=development
export GAE_VERSION=doc-sample-${PROJECT}-${APPENGINE_ENVIRONMENT}
export GAE_VERSION=doc-sample-$(echo $PROJECT | sed 's_/_-_g')

# Register post-test cleanup
function cleanup {
Expand Down

0 comments on commit 12a666d

Please sign in to comment.