feat!: drop node8, remove eslint, update gax, fix generated protos, r…

…un the generator (#423)
GoogleCloudPlatform · Nov 17, 2022 · eb9c042 · eb9c042
1 parent 125e563
commit eb9c042
Show file tree

Hide file tree

Showing 19 changed files with 57 additions and 55 deletions.
diff --git a/video-intelligence/analyze-streaming-annotation-to-storage.js b/video-intelligence/analyze-streaming-annotation-to-storage.js
@@ -52,7 +52,7 @@ async function main(path = 'YOUR_LOCAL_FILE', outputUri = 'PATH_TO_OUTPUT') {
       };
       chunks.push(request);
     })
-    .on('close', function() {
+    .on('close', () => {
       // configRequest should be the first in the stream of requests
       stream.write(configRequest);
       for (let i = 0; i < chunks.length; i++) {

diff --git a/video-intelligence/analyze-streaming-automl-classification.js b/video-intelligence/analyze-streaming-automl-classification.js
@@ -62,7 +62,7 @@ async function main(
       };
       chunks.push(request);
     })
-    .on('close', function() {
+    .on('close', () => {
       // configRequest should be the first in the stream of requests
       stream.write(configRequest);
       for (let i = 0; i < chunks.length; i++) {

diff --git a/video-intelligence/analyze-streaming-labels.js b/video-intelligence/analyze-streaming-labels.js
@@ -46,7 +46,7 @@ async function main(path = 'YOUR_LOCAL_FILE') {
       };
       chunks.push(request);
     })
-    .on('close', function() {
+    .on('close', () => {
       // configRequest should be the first in the stream of requests
       stream.write(configRequest);
       for (let i = 0; i < chunks.length; i++) {

diff --git a/video-intelligence/analyze-streaming-object.js b/video-intelligence/analyze-streaming-object.js
@@ -46,7 +46,7 @@ async function main(path = 'YOUR_LOCAL_FILE') {
       };
       chunks.push(request);
     })
-    .on('close', function() {
+    .on('close', () => {
       // configRequest should be the first in the stream of requests
       stream.write(configRequest);
       for (let i = 0; i < chunks.length; i++) {
@@ -70,7 +70,7 @@ async function main(path = 'YOUR_LOCAL_FILE') {
       );
       //Every annotation has only one frame.
       const box = object.frames[0].normalizedBoundingBox;
-      console.log(`Bounding box position:`);
+      console.log('Bounding box position:');
       console.log(` left  :${box.left}`);
       console.log(` top   :${box.top}`);
       console.log(` right :${box.right}`);

diff --git a/video-intelligence/analyze-streaming-safe-search.js b/video-intelligence/analyze-streaming-safe-search.js
@@ -47,7 +47,7 @@ async function main(path = 'YOUR_LOCAL_FILE') {
       };
       chunks.push(request);
     })
-    .on('close', function() {
+    .on('close', () => {
       // configRequest should be the first in the stream of requests
       stream.write(configRequest);
       for (let i = 0; i < chunks.length; i++) {

diff --git a/video-intelligence/analyze-streaming-shot-change.js b/video-intelligence/analyze-streaming-shot-change.js
@@ -46,7 +46,7 @@ async function main(path = 'YOUR_LOCAL_FILE') {
       };
       chunks.push(request);
     })
-    .on('close', function() {
+    .on('close', () => {
       // configRequest should be the first in the stream of requests
       stream.write(configRequest);
       for (let i = 0; i < chunks.length; i++) {
@@ -61,7 +61,7 @@ async function main(path = 'YOUR_LOCAL_FILE') {
     const shotChanges = annotations.shotAnnotations;
     console.log(JSON.stringify(shotChanges));
     if (shotChanges.length === 1) {
-      console.log(`The entire video is one shot.`);
+      console.log('The entire video is one shot.');
     }
     shotChanges.forEach(shot => {
       console.log(

diff --git a/video-intelligence/analyze.js b/video-intelligence/analyze.js
@@ -163,7 +163,7 @@ async function analyzeShots(gcsUri) {
   console.log('Shot changes:');
 
   if (shotChanges.length === 1) {
-    console.log(`The entire video is one shot.`);
+    console.log('The entire video is one shot.');
   } else {
     shotChanges.forEach((shot, shotIdx) => {
       console.log(`Scene ${shotIdx} occurs from:`);
@@ -344,7 +344,7 @@ async function analyzeTextGCS(gcsUri) {
           `Time offset for the frame: ${timeOffset.seconds || 0}` +
             `.${(timeOffset.nanos / 1e6).toFixed(0)}s`
         );
-        console.log(`Rotated Bounding Box Vertices:`);
+        console.log('Rotated Bounding Box Vertices:');
         frame.rotatedBoundingBox.vertices.forEach(vertex => {
           console.log(`Vertex.x:${vertex.x}, Vertex.y:${vertex.y}`);
         });
@@ -399,7 +399,7 @@ async function analyzeObjectTrackingGCS(gcsUri) {
       `Time offset for the first frame: ${timeOffset.seconds || 0}` +
         `.${(timeOffset.nanos / 1e6).toFixed(0)}s`
     );
-    console.log(`Bounding box position:`);
+    console.log('Bounding box position:');
     console.log(` left   :${box.left}`);
     console.log(` top    :${box.top}`);
     console.log(` right  :${box.right}`);
@@ -468,7 +468,7 @@ async function analyzeText(path) {
           `Time offset for the frame: ${timeOffset.seconds || 0}` +
             `.${(timeOffset.nanos / 1e6).toFixed(0)}s`
         );
-        console.log(`Rotated Bounding Box Vertices:`);
+        console.log('Rotated Bounding Box Vertices:');
         frame.rotatedBoundingBox.vertices.forEach(vertex => {
           console.log(`Vertex.x:${vertex.x}, Vertex.y:${vertex.y}`);
         });
@@ -526,7 +526,7 @@ async function analyzeObjectTracking(path) {
       `Time offset for the first frame: ${timeOffset.seconds || 0}` +
         `.${(timeOffset.nanos / 1e6).toFixed(0)}s`
     );
-    console.log(`Bounding box position:`);
+    console.log('Bounding box position:');
     console.log(` left   :${box.left}`);
     console.log(` top    :${box.top}`);
     console.log(` right  :${box.right}`);
@@ -536,77 +536,79 @@ async function analyzeObjectTracking(path) {
 }
 
 async function main() {
-  require(`yargs`)
+  require('yargs')
     .demand(1)
     .command(
-      `shots <gcsUri>`,
-      `Analyzes shot angles in a video stored in Google Cloud Storage using the Cloud Video Intelligence API.`,
+      'shots <gcsUri>',
+      'Analyzes shot angles in a video stored in Google Cloud Storage using the Cloud Video Intelligence API.',
       {},
       opts => analyzeShots(opts.gcsUri)
     )
     .command(
-      `labels-gcs <gcsUri>`,
-      `Labels objects in a video stored in Google Cloud Storage using the Cloud Video Intelligence API.`,
+      'labels-gcs <gcsUri>',
+      'Labels objects in a video stored in Google Cloud Storage using the Cloud Video Intelligence API.',
       {},
       opts => analyzeLabelsGCS(opts.gcsUri)
     )
     .command(
-      `labels-file <filePath>`,
-      `Labels objects in a video stored locally using the Cloud Video Intelligence API.`,
+      'labels-file <filePath>',
+      'Labels objects in a video stored locally using the Cloud Video Intelligence API.',
       {},
       opts => analyzeLabelsLocal(opts.filePath)
     )
     .command(
-      `safe-search <gcsUri>`,
-      `Detects explicit content in a video stored in Google Cloud Storage.`,
+      'safe-search <gcsUri>',
+      'Detects explicit content in a video stored in Google Cloud Storage.',
       {},
       opts => analyzeSafeSearch(opts.gcsUri)
     )
     .command(
-      `transcription <gcsUri>`,
-      `Extract the video transcription using the Cloud Video Intelligence API.`,
+      'transcription <gcsUri>',
+      'Extract the video transcription using the Cloud Video Intelligence API.',
       {},
       opts => analyzeVideoTranscription(opts.gcsUri)
     )
     .command(
-      `video-text-gcs <gcsUri>`,
-      `Analyzes text in a video stored in Google Cloud Storage using the Cloud Video Intelligence API.`,
+      'video-text-gcs <gcsUri>',
+      'Analyzes text in a video stored in Google Cloud Storage using the Cloud Video Intelligence API.',
       {},
       opts => analyzeTextGCS(opts.gcsUri)
     )
     .command(
-      `track-objects-gcs <gcsUri>`,
-      `Analyzes objects in a video stored in Google Cloud Storage using the Cloud Video Intelligence API.`,
+      'track-objects-gcs <gcsUri>',
+      'Analyzes objects in a video stored in Google Cloud Storage using the Cloud Video Intelligence API.',
       {},
       opts => analyzeObjectTrackingGCS(opts.gcsUri)
     )
     .command(
-      `video-text <path>`,
-      `Analyzes text in a video stored in a local file using the Cloud Video Intelligence API.`,
+      'video-text <path>',
+      'Analyzes text in a video stored in a local file using the Cloud Video Intelligence API.',
       {},
       opts => analyzeText(opts.path)
     )
     .command(
-      `track-objects <path>`,
-      `Analyzes objects in a video stored in a local file using the Cloud Video Intelligence API.`,
+      'track-objects <path>',
+      'Analyzes objects in a video stored in a local file using the Cloud Video Intelligence API.',
       {},
       opts => analyzeObjectTracking(opts.path)
     )
-    .example(`node $0 shots gs://cloud-samples-data/video/googlework_short.mp4`)
-    .example(`node $0 labels-gcs gs://cloud-samples-data/video/cat.mp4`)
-    .example(`node $0 labels-file googlework_short.mp4`)
-    .example(`node $0 safe-search gs://cloud-samples-data/video/googlework_short.mp4`)
-    .example(`node $0 transcription gs://cloud-samples-data/video/cat.mp4`)
-    .example(`node $0 video-text ./resources/googlework_short.mp4`)
+    .example('node $0 shots gs://cloud-samples-data/video/googlework_short.mp4')
+    .example('node $0 labels-gcs gs://cloud-samples-data/video/cat.mp4')
+    .example('node $0 labels-file googlework_short.mp4')
     .example(
-      `node $0 video-text-gcs gs://nodejs-docs-samples/video/googlework_short.mp4`
+      'node $0 safe-search gs://cloud-samples-data/video/googlework_short.mp4'
     )
-    .example(`node $0 track-objects ./resources/googlework_short.mp4`)
-    .example(`node $0 track-objects-gcs gs://nodejs-docs-samples/video/cat.mp4`)
+    .example('node $0 transcription gs://cloud-samples-data/video/cat.mp4')
+    .example('node $0 video-text ./resources/googlework_short.mp4')
+    .example(
+      'node $0 video-text-gcs gs://nodejs-docs-samples/video/googlework_short.mp4'
+    )
+    .example('node $0 track-objects ./resources/googlework_short.mp4')
+    .example('node $0 track-objects-gcs gs://nodejs-docs-samples/video/cat.mp4')
     .wrap(120)
     .recommendCommands()
     .epilogue(
-      `For more information, see https://cloud.google.com/video-intelligence/docs`
+      'For more information, see https://cloud.google.com/video-intelligence/docs'
     )
     .help()
     .strict().argv;

diff --git a/video-intelligence/system-test/analyze-streaming-annotation-to-storage.test.js b/video-intelligence/system-test/analyze-streaming-annotation-to-storage.test.js
@@ -19,7 +19,7 @@ const {assert} = require('chai');
 const {describe, it} = require('mocha');
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const cmd = `node analyze-streaming-annotation-to-storage.js`;
+const cmd = 'node analyze-streaming-annotation-to-storage.js';
 const project = process.env.GCLOUD_PROJECT;
 const file = 'resources/googlework_short.mp4';
 const outputUri = 'gs://' + project + '/VIDEO_STREAMING_OUTPUT';

diff --git a/video-intelligence/system-test/analyze-streaming-automl-classification.test.js b/video-intelligence/system-test/analyze-streaming-automl-classification.test.js
@@ -20,8 +20,8 @@ const {describe, it} = require('mocha');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const cmd = `node analyze-streaming-automl-classification.js`;
-const modelId = `VCN3094808572840640512`;
+const cmd = 'node analyze-streaming-automl-classification.js';
+const modelId = 'VCN3094808572840640512';
 const project = process.env.GCLOUD_PROJECT;
 const file = 'resources/googlework_short.mp4';
 

diff --git a/video-intelligence/system-test/analyze-streaming-labels.test.js b/video-intelligence/system-test/analyze-streaming-labels.test.js
@@ -20,7 +20,7 @@ const {describe, it} = require('mocha');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const cmd = `node analyze-streaming-labels.js`;
+const cmd = 'node analyze-streaming-labels.js';
 const file = 'resources/googlework_short.mp4';
 
 describe('streaming label', () => {

diff --git a/video-intelligence/system-test/analyze-streaming-object.test.js b/video-intelligence/system-test/analyze-streaming-object.test.js
@@ -20,7 +20,7 @@ const {describe, it} = require('mocha');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const cmd = `node analyze-streaming-object.js`;
+const cmd = 'node analyze-streaming-object.js';
 const file = 'resources/googlework_short.mp4';
 
 describe('streaming object', () => {

diff --git a/video-intelligence/system-test/analyze-streaming-safe-search.test.js b/video-intelligence/system-test/analyze-streaming-safe-search.test.js
@@ -19,7 +19,7 @@ const {assert} = require('chai');
 const {describe, it} = require('mocha');
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const cmd = `node analyze-streaming-safe-search.js`;
+const cmd = 'node analyze-streaming-safe-search.js';
 const file = 'resources/googlework_short.mp4';
 
 describe('streaming safe search', () => {

diff --git a/video-intelligence/system-test/analyze-streaming-shot-change.test.js b/video-intelligence/system-test/analyze-streaming-shot-change.test.js
@@ -20,7 +20,7 @@ const {describe, it} = require('mocha');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const cmd = `node analyze-streaming-shot-change.js`;
+const cmd = 'node analyze-streaming-shot-change.js';
 const file = 'resources/googlework_short.mp4';
 
 describe('streaming shot change', () => {

diff --git a/video-intelligence/system-test/analyze_face_detection.test.js b/video-intelligence/system-test/analyze_face_detection.test.js
@@ -20,7 +20,7 @@ const {describe, it} = require('mocha');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const cmd = `node analyze_face_detection.js`;
+const cmd = 'node analyze_face_detection.js';
 const file = 'resources/googlework_short.mp4';
 
 describe('analyzing faces in video', () => {

diff --git a/video-intelligence/system-test/analyze_face_detection_gcs.test.js b/video-intelligence/system-test/analyze_face_detection_gcs.test.js
@@ -20,7 +20,7 @@ const {describe, it} = require('mocha');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const cmd = `node analyze_face_detection_gcs.js`;
+const cmd = 'node analyze_face_detection_gcs.js';
 const gcsUri = 'gs://cloud-samples-data/video/googlework_short.mp4';
 
 describe('analyzing faces in video', () => {

diff --git a/video-intelligence/system-test/analyze_person_detection.test.js b/video-intelligence/system-test/analyze_person_detection.test.js
@@ -20,7 +20,7 @@ const {describe, it} = require('mocha');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const cmd = `node analyze_person_detection.js`;
+const cmd = 'node analyze_person_detection.js';
 const file = 'resources/googlework_short.mp4';
 
 describe('analyzing people in video', () => {

diff --git a/video-intelligence/system-test/analyze_person_detection_gcs.test.js b/video-intelligence/system-test/analyze_person_detection_gcs.test.js
@@ -20,7 +20,7 @@ const {describe, it} = require('mocha');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const cmd = `node analyze_person_detection_gcs.js`;
+const cmd = 'node analyze_person_detection_gcs.js';
 const gcsUri = 'gs://cloud-samples-data/video/googlework_short.mp4';
 
 describe('analyzing people in video', () => {

diff --git a/video-intelligence/system-test/detect_logo.test.js b/video-intelligence/system-test/detect_logo.test.js
@@ -20,7 +20,7 @@ const {describe, it} = require('mocha');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const cmd = `node detect_logo.js`;
+const cmd = 'node detect_logo.js';
 const file = 'resources/googlework_short.mp4';
 
 describe('analyzing logos in video', () => {

diff --git a/video-intelligence/system-test/detect_logo_gcs.test.js b/video-intelligence/system-test/detect_logo_gcs.test.js
@@ -20,7 +20,7 @@ const {describe, it} = require('mocha');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const cmd = `node detect_logo_gcs.js`;
+const cmd = 'node detect_logo_gcs.js';
 const file = 'gs://cloud-samples-data/video/googlework_short.mp4';
 
 describe('analyzing logos in video on gcs', () => {