Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment URL points to 404 #574

Closed
scotthmurray opened this issue Mar 1, 2018 · 0 comments · Fixed by #577
Closed

Comment URL points to 404 #574

scotthmurray opened this issue Mar 1, 2018 · 0 comments · Fixed by #577

Comments

@scotthmurray
Copy link

The URL mentioned in a comment here:

nodejs-docs-samples/auth/auth.js

Line 57 in c91fef0

// helper, see https://googlecloudplatform.github.io/google-cloud-node/#/docs/google-cloud/latest/guides/authentication

…points to a 404 page.

Please consider updating this URL to point to the intended page. Thanks!
@campionfellin campionfellin mentioned this issue Mar 10, 2018
Merged
@snyk-bot snyk-bot mentioned this issue Aug 27, 2020
Open
This was referenced Sep 3, 2020
Open
Open
This was referenced Jan 11, 2022
Open
Open
This was referenced Mar 21, 2022
Open
Open
ahrarmonsur pushed a commit that referenced this issue Nov 8, 2022
@bcoe
fix(build): update branch to main (#574)
1ed81e2
ahrarmonsur pushed a commit that referenced this issue Nov 8, 2022
@release-please
chore: release 2.3.5 (#575)
73d29a4 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.5](https://www.github.com/googleapis/nodejs-monitoring/compare/v2.3.4...v2.3.5) (2021-09-08)


### Bug Fixes

* **build:** update branch to main ([#574](https://www.github.com/googleapis/nodejs-monitoring/issues/574)) ([955622f](https://www.github.com/googleapis/nodejs-monitoring/commit/955622f40583247a78301340fc172c9d42fa1354))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@ahrarmonsur ahrarmonsur mentioned this issue Nov 8, 2022
Merged
ace-n pushed a commit that referenced this issue Nov 10, 2022
@bcoe
fix(build): update branch to main (#574)
b69e84c
ace-n pushed a commit that referenced this issue Nov 10, 2022
@release-please
chore: release 2.3.5 (#575)
c648052 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.5](https://www.github.com/googleapis/nodejs-monitoring/compare/v2.3.4...v2.3.5) (2021-09-08)


### Bug Fixes

* **build:** update branch to main ([#574](https://www.github.com/googleapis/nodejs-monitoring/issues/574)) ([955622f](https://www.github.com/googleapis/nodejs-monitoring/commit/955622f40583247a78301340fc172c9d42fa1354))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this issue Nov 16, 2022
@release-please
chore: release 3.21.0 (#576)
703352e 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.21.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.20.0...v3.21.0) (2021-11-09)


### Features

* OSConfig: add OS policy assignment rpcs ([#574](https://www.github.com/googleapis/nodejs-asset/issues/574)) ([ff9491d](https://www.github.com/googleapis/nodejs-asset/commit/ff9491d55bd527c451914b487ce08fed3068dbd8))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this issue Nov 16, 2022
@release-please
chore: release 3.21.0 (#576)
e6bc7c2 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.21.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.20.0...v3.21.0) (2021-11-09)


### Features

* OSConfig: add OS policy assignment rpcs ([#574](https://www.github.com/googleapis/nodejs-asset/issues/574)) ([ff9491d](https://www.github.com/googleapis/nodejs-asset/commit/ff9491d55bd527c451914b487ce08fed3068dbd8))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this issue Nov 16, 2022
@release-please
chore: release 3.3.5 (#574)
24b3ab8 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.3.5](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.4...v3.3.5) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#573](https://www.github.com/googleapis/nodejs-video-intelligence/issues/573)) ([afb19b5](https://www.github.com/googleapis/nodejs-video-intelligence/commit/afb19b5d54518d672e761881110c69e78276f80c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this issue Nov 16, 2022
@release-please
chore: release 3.21.0 (#576)
7c2dcf6 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.21.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.20.0...v3.21.0) (2021-11-09)


### Features

* OSConfig: add OS policy assignment rpcs ([#574](https://www.github.com/googleapis/nodejs-asset/issues/574)) ([ff9491d](https://www.github.com/googleapis/nodejs-asset/commit/ff9491d55bd527c451914b487ce08fed3068dbd8))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@ace-n ace-n mentioned this issue Nov 16, 2022
Merged
ahrarmonsur pushed a commit that referenced this issue Nov 16, 2022
@release-please
chore: release 3.21.0 (#576)
4439fca 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.21.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.20.0...v3.21.0) (2021-11-09)


### Features

* OSConfig: add OS policy assignment rpcs ([#574](https://www.github.com/googleapis/nodejs-asset/issues/574)) ([ff9491d](https://www.github.com/googleapis/nodejs-asset/commit/ff9491d55bd527c451914b487ce08fed3068dbd8))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this issue Nov 16, 2022
@release-please
chore: release 3.21.0 (#576)
ddd6973 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.21.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.20.0...v3.21.0) (2021-11-09)


### Features

* OSConfig: add OS policy assignment rpcs ([#574](https://www.github.com/googleapis/nodejs-asset/issues/574)) ([ff9491d](https://www.github.com/googleapis/nodejs-asset/commit/ff9491d55bd527c451914b487ce08fed3068dbd8))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this issue Nov 17, 2022
@release-please
chore: release 3.3.5 (#574)
e6fd40c 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.3.5](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.4...v3.3.5) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#573](https://www.github.com/googleapis/nodejs-video-intelligence/issues/573)) ([afb19b5](https://www.github.com/googleapis/nodejs-video-intelligence/commit/afb19b5d54518d672e761881110c69e78276f80c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this issue Nov 17, 2022
@release-please
chore: release 3.21.0 (#576)
8b3f91c 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.21.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.20.0...v3.21.0) (2021-11-09)


### Features

* OSConfig: add OS policy assignment rpcs ([#574](https://www.github.com/googleapis/nodejs-asset/issues/574)) ([ff9491d](https://www.github.com/googleapis/nodejs-asset/commit/ff9491d55bd527c451914b487ce08fed3068dbd8))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this issue Nov 17, 2022
@release-please @ahrarmonsur
chore: release 3.3.5 (#574)
dbf52be 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.3.5](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.4...v3.3.5) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#573](https://www.github.com/googleapis/nodejs-video-intelligence/issues/573)) ([afb19b5](https://www.github.com/googleapis/nodejs-video-intelligence/commit/afb19b5d54518d672e761881110c69e78276f80c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this issue Nov 18, 2022
@alexander-fenster
feat!: drop node8 support, support for async iterators (#574)
e1e7aca 
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
ahrarmonsur pushed a commit that referenced this issue Nov 18, 2022
@alexander-fenster
feat!: drop node8 support, support for async iterators (#574)
033d756 
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
@ahrarmonsur ahrarmonsur mentioned this issue Nov 18, 2022
Merged
NimJay pushed a commit that referenced this issue Nov 18, 2022
@alexander-fenster @NimJay
feat!: drop node8 support, support for async iterators (#574)
7f3f4ca 
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix comment URL 404
1 participant
@scotthmurray