Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint: add 'prefer-template' rule #1367

Merged
merged 4 commits into from
Jul 8, 2019
Merged

Lint: add 'prefer-template' rule #1367

merged 4 commits into from
Jul 8, 2019

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Jun 14, 2019

(Encourages the use of ES6 template strings.)

@ace-n ace-n requested a review from fhinkel June 14, 2019 00:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Jun 18, 2019

Will this change regular strings to templates, too? E.g., in require(`dep`)?

@ace-n
Copy link
Contributor Author

ace-n commented Jun 24, 2019 •
edited
Loading

@fhinkel no - that would be the quote rule. (This one mainly deals with string concatenation.)

Happy to add that rule if you'd like me to though.

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@fhinkel fhinkel merged commit 743587b into master Jul 8, 2019
@fhinkel fhinkel deleted the lint-config branch July 8, 2019 16:34
@grant grant mentioned this pull request Sep 23, 2019
Closed
@dlminvestments dlminvestments mentioned this pull request Jun 23, 2022
Merged
@ninadhatkar ninadhatkar mentioned this pull request Dec 5, 2022
Open
@dlminvestments dlminvestments mentioned this pull request Dec 5, 2023
Open
@aqualen aqualen mentioned this pull request Dec 5, 2023
Open
@dlminvestments dlminvestments mentioned this pull request Dec 6, 2023
Open
This was referenced Dec 6, 2023
Open
Open
@aqualen aqualen mentioned this pull request Dec 27, 2023
Open
This was referenced Dec 27, 2023
Open
Open
This was referenced Dec 28, 2023
Open
Open
@aqualen aqualen mentioned this pull request Jan 5, 2024
Open
@dlminvestments dlminvestments mentioned this pull request Jan 5, 2024
Open
This was referenced Jan 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ace-n @fhinkel @googlebot @kokoro-team