Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make functions_http_method consistent with other samples #1376

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Jun 21, 2019

Inline function handlers like in Go and Python. It looks weird (and is unnecessary) having standalone functions.

See:
https://cloud.google.com/functions/docs/writing/http#handling_http_methods

@grant grant requested a review from ace-n June 21, 2019 16:03
@grant grant self-assigned this Jun 21, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2019
@grant grant merged commit bda5a4d into master Jun 21, 2019
@grant grant deleted the grant-patch-1 branch June 21, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants