Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions/imagemagick: system tests + Node 8 upgrade #1387

Merged
merged 29 commits into from
Jul 25, 2019
Merged

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Jun 26, 2019

No description provided.

@ace-n ace-n requested a review from fhinkel June 26, 2019 20:58
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2019
@ace-n ace-n added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Jul 8, 2019

@ace-n The imagemagick tests are failing. Ping me when it's ready for another review

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 15, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Jul 23, 2019

Linter is complaining and a few other required tests don't pass. Can you have another look?

@ace-n ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2019
@ace-n ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Jul 23, 2019

The imagemagick tests are failing again :(

@fhinkel fhinkel merged commit deae667 into master Jul 25, 2019
@fhinkel fhinkel deleted the gcf-imagick-node8 branch July 25, 2019 02:38
This was referenced Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants