Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove functions_concepts_after_response #1491

Closed
wants to merge 1 commit into from

Conversation

grant
Copy link
Contributor

@grant grant commented Sep 20, 2019

Removes functions_concepts_after_response.

This is not a useful GCF function, does not have a test, and does not have a strong reason to keep for N languages. Only implemented in Node right now.

samples/596
Doc: https://cloud.google.com/functions/docs/concepts/exec#function_execution_timeline

@grant grant requested a review from ace-n as a code owner September 20, 2019 20:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2019
@grant grant self-assigned this Sep 20, 2019
@ace-n
Copy link
Contributor

ace-n commented Sep 20, 2019

Personally I think that we should keep this (since it's useful for explaining the related concept), but I'll defer to @labtopia

@labtopia
Copy link
Contributor

This may not be the very best sample we could have had here, but I think the underlying concept is important, and the sample does illustrate it. Further, this doesn't seem like a case where we need a sample for every runtime. A single sample illustrating the concept is sufficient. I think the section would be a lot weaker without the sample. Therefore, I am not in favor of removing it.

@grant
Copy link
Contributor Author

grant commented Sep 23, 2019

I'd rather have the one place in our docs have something shorter so the reader doesn't need to read the whole sample:

res.end();

// This statement may not execute
console.log('Function complete!');

What about moving the region tags to just show this (above)?

@ace-n
Copy link
Contributor

ace-n commented Sep 23, 2019

Middle ground - how about we exclude the JSDoc comment with the region tags, to clearly delineate that this code is (still) within a function?

@grant
Copy link
Contributor Author

grant commented Sep 25, 2019

Closing due to lack of interest in changing this sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants