Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reduce request usage #1606

Merged
merged 5 commits into from
Feb 25, 2020
Merged

test: reduce request usage #1606

merged 5 commits into from
Feb 25, 2020

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Feb 17, 2020

The request module is officially deprecated:
https://www.npmjs.com/package/request

This is removing one usage of it, and replacing it with gaxios. Hope is that we can use this as a template for others to make this change as we go along as well.

This change also includes:

  • removing unused supertest package
  • doing a deterministic wait on the host/port, instead of counting on retries

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 24, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 24, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 25, 2020
@fhinkel fhinkel merged commit f9e24c4 into master Feb 25, 2020
@fhinkel fhinkel deleted the nor1 branch February 25, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants