Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

functions/slack: config.json -> env vars #1751

Merged
merged 2 commits into from
Apr 28, 2020
Merged

functions/slack: config.json -> env vars #1751

merged 2 commits into from
Apr 28, 2020

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Apr 27, 2020

Do not merge until @labtopia updates the docs accordingly.

@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 27, 2020
@ace-n ace-n requested a review from fhinkel April 27, 2020 21:56
@ace-n ace-n requested a review from grant as a code owner April 27, 2020 21:56
@ace-n ace-n self-assigned this Apr 27, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2020
@ace-n
Copy link
Contributor Author

ace-n commented Apr 28, 2020

@labtopia LGTMed internally, merging. ✅

@ace-n ace-n added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Apr 28, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit da03d9b into master Apr 28, 2020
@ace-n ace-n deleted the slack-env branch April 28, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@grant grant Awaiting requested review from grant

Assignees

@ace-n ace-n

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ace-n @fhinkel @googlebot