Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the App Engine Redis sample #1864

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

michaelawyu
Copy link
Contributor

@michaelawyu michaelawyu commented Jun 8, 2020

This sample is no longer featured in the documentation and has been replaced by the Memorystore for Redis + App Engine sample (/memorystore/redis).

See also cl/315371333.

Fixes #1690, #1691, #1800.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 8, 2020
@michaelawyu michaelawyu requested review from fhinkel and ace-n June 8, 2020 23:06
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kokoro files on GitHub need to be deleted, too.

@michaelawyu
Copy link
Contributor Author

michaelawyu commented Jun 8, 2020

My bad. The configs have been removed. @fhinkel

@fhinkel fhinkel merged commit 2b101c2 into master Jun 8, 2020
@fhinkel fhinkel deleted the michaelawyu-patch-appengine-redis branch November 5, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appengine/redis: should be listening failed
3 participants