Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup tests and applied minor fixes for the App Engine Websockets sample #1865

Merged
merged 13 commits into from
Aug 6, 2020
Merged

Setup tests and applied minor fixes for the App Engine Websockets sample #1865

merged 13 commits into from
Aug 6, 2020

Conversation

michaelawyu
Copy link
Contributor

@michaelawyu michaelawyu commented Jun 8, 2020 •
edited
Loading

See also cl/315382224.

Fixes #1825.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 8, 2020
@michaelawyu michaelawyu requested review from ace-n and fhinkel June 8, 2020 23:56
ace-n
ace-n approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a nit 🙂

appengine/websockets/test/index.test.js Outdated Show resolved Hide resolved
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 11, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 11, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 11, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 11, 2020
@fhinkel
Copy link
Contributor

fhinkel commented Jun 11, 2020

The websockets tests are failing.

@michaelawyu
Copy link
Contributor Author

michaelawyu commented Jun 12, 2020 •
edited
Loading

The tests failed as the Docker image Kokoro uses does not have libX11-xcb installed, which is required for Puppeteer to run. The Puppeteer test is disabled in the test environment for now.

@michaelawyu michaelawyu changed the title Setup tests and applied Minor fixes for the App Engine Websockets sample Setup tests and applied minor fixes for the App Engine Websockets sample Jun 12, 2020
@fhinkel
Copy link
Contributor

fhinkel commented Jun 17, 2020 •
edited
Loading

Wouldn't it make more sense to add the package to the docker image? I'm against disabling the index.test.js test instead of fixing them.

@michaelawyu
Copy link
Contributor Author

michaelawyu commented Jun 17, 2020 •
edited
Loading

@fhinkel I do agree and I think the same way. However I am not sure what the right steps are (or more precisely whose approvals I should have for doing this) to update the docker image. I do have access to the container registry but I assume simply pushing a new image version might not be a good idea.

@fhinkel
Copy link
Contributor

fhinkel commented Jun 17, 2020

Can you ask in the DPE chat, usually there's no objections to making changes.

@michaelawyu
Copy link
Contributor Author

Note: A new image node:10-puppeteer has been added.

@michaelawyu michaelawyu added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@michaelawyu michaelawyu added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@michaelawyu michaelawyu added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@michaelawyu
Copy link
Contributor Author

All related tests have passed.

@grayside grayside added the automerge Merge the pull request once unit tests and other checks pass. label Aug 6, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 146ffdb into master Aug 6, 2020
@fhinkel fhinkel deleted the michaelawyu-patch-appengine-websockets branch August 17, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees

@michaelawyu michaelawyu

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build error
6 participants
@michaelawyu @fhinkel @ace-n @grayside @googlebot @kokoro-team