Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate code from googleapis/nodejs-containeranalysis #2834

Merged
merged 138 commits into from
Nov 11, 2022

Conversation

NimJay
Copy link
Contributor

@NimJay NimJay commented Nov 11, 2022

This is a redo of #2833 which is a redo of #2816 (comment).
Do not use a merge commit to update this pull-request with main.


murog and others added 30 commits May 7, 2019 19:17
* chore(main): release 4.3.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 11, 2022
@google-cla
Copy link

google-cla bot commented Nov 11, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@NimJay
Copy link
Contributor Author

NimJay commented Nov 11, 2022

Reminder: do not use a merge commit to update this pull-request (source branch) with main.
Use rebase instead.

// [END containeranalysis_quickstart]
}

main(...process.argv.slice(2));
Copy link
Contributor Author

@NimJay NimJay Nov 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are keeping the quickstart.js because it's used in this cloud.google.com page.
We are supposed to treat the quickstart.js just like any other sample: if it's being used, migrate it.

@NimJay NimJay marked this pull request as ready for review November 11, 2022 16:52
@NimJay NimJay requested review from a team as code owners November 11, 2022 16:52
@snippet-bot
Copy link

snippet-bot bot commented Nov 11, 2022

Here is the summary of changes.

You are about to add 15 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@NimJay NimJay enabled auto-merge (rebase) November 11, 2022 16:58
auto-merge was automatically disabled November 11, 2022 17:16

Rebase failed

@NimJay NimJay enabled auto-merge (rebase) November 11, 2022 17:50
auto-merge was automatically disabled November 11, 2022 17:53

Rebase failed

@ace-n ace-n enabled auto-merge November 11, 2022 20:01
@ace-n
Copy link
Contributor

ace-n commented Nov 11, 2022

Using merge commit per @sofisl's suggestion

@NimJay NimJay disabled auto-merge November 11, 2022 22:18
@NimJay NimJay merged commit 2668a58 into main Nov 11, 2022
@NimJay NimJay deleted the nodejs-containeranalysis-migration branch November 11, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.