migrate code from googleapis/nodejs-video-stitcher #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
irataxy
commented
Jan 13, 2023
irataxy
commented
- feat: add templated files from docker image
- feat: add initial samples (Add linting. #2)
- docs(samples): add Video Stitcher slate and CDN key code samples and tests (pr/5 #6)
- docs(samples): add Video Stitcher VOD and live session code samples a… (Add appengine/meteor sample #9)
- docs(samples): add try/catch to delete operations in testing (Added mailgun example. #19)
- chore(main): release 0.1.1 (add datastore v1beta3 snippets #16)
- chore(main): release 0.2.0 (Add integrations tests that check that samples deploy #21)
- chore(main): release 0.2.1 (clean up memcache sample #25)
- chore(main): release 0.2.2 (Added readme for datastore samples #29)
- docs(samples): Fix Video Stitcher region tag prefix (Upgrade to latest nodejs LTS release #36)
- chore(main): release 0.3.0 (Getting datastore tests running on CI. #30)
Release-As: v0.1.0
…tests (#6) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [X] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/nodejs-video-stitcher/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [X] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes b:202972969
#9) * docs(samples): add Video Stitcher VOD and live session code samples and tests * Remove async from slate and live session before and after hooks * clean out old slates and CDN keys * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update SHA Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* add try/catch to delete operations in testing * refactor test file; use timestamp for resource names, clean up resources over an hour old, move create and delete operations to before and after hooks in each test suite * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.1.1](googleapis/nodejs-video-stitcher@v0.1.0...v0.1.1) (2022-06-23) ### Bug Fixes * **deps:** update dependency google-gax to v3 ([#15](googleapis/nodejs-video-stitcher#15)) ([345085f](googleapis/nodejs-video-stitcher@345085f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(main): release 0.2.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(main): release 0.2.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.3.0](https://togithub.com/googleapis/nodejs-video-stitcher/compare/v0.2.2...v0.3.0) (2022-12-20) ### Features * Add support for Media CDN ([83f1257](https://togithub.com/googleapis/nodejs-video-stitcher/commit/83f1257b790abc8ef7acedb8e009ef5e94a0c710)) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#40](https://togithub.com/googleapis/nodejs-video-stitcher/issues/40)) ([effa481](https://togithub.com/googleapis/nodejs-video-stitcher/commit/effa4814da8b7d81b6c5be6b6e580a683f02c50e)) * Do not import the whole google-gax from proto JS ([#1553](https://togithub.com/googleapis/nodejs-video-stitcher/issues/1553)) ([#27](https://togithub.com/googleapis/nodejs-video-stitcher/issues/27)) ([b7fe723](https://togithub.com/googleapis/nodejs-video-stitcher/commit/b7fe723d1a2dfb229b69640ca749398805573e56)) * Preserve default values in x-goog-request-params header ([#32](https://togithub.com/googleapis/nodejs-video-stitcher/issues/32)) ([28c3214](https://togithub.com/googleapis/nodejs-video-stitcher/commit/28c32148f4707550c6c6a143c7556560d6b21230)) * Regenerated protos JS and TS definitions ([#43](https://togithub.com/googleapis/nodejs-video-stitcher/issues/43)) ([8f7481e](https://togithub.com/googleapis/nodejs-video-stitcher/commit/8f7481ed1f5fc054abe6430e43570851c39740d0)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
product-auto-label
bot
added
the
samples
added 2 commits
January 13, 2023 14:26
|
Here is the summary of changes. You are about to add 20 region tags.
This comment is generated by snippet-bot.
|
ace-n
suggested changes
Jan 13, 2023
media/video-stitcher/quickstart.js
Outdated
| 'use strict'; | ||
|
|
||
| function main(parent) { | ||
| // [START videostitcher_v1_generated_VideoStitcherService_ListCdnKeys_async] |
There was a problem hiding this comment.
This sample isn't used in the docs. Do we need it here?
|
|
||
| 'use strict'; | ||
|
|
||
| const path = require('path'); |
There was a problem hiding this comment.
Do we need this file, if quickstart.js is itself not in the docs?
(If we do, this file should be named quickstart.test.js.)
kokoro-team
removed
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.