Update gcloud-node datastore snippets #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pcostell
commented
Nov 17, 2015
pcostell
commented
- Fixes small typos in the region tags
- Rearranged the build_service snippet to include the correct region.
|
@stephenplusplus Could you take a look? |
| @@ -22,12 +21,16 @@ if (!projectId) { | |||
| throw new Error('TEST_PROJECT_ID environment variable required.'); | |||
| } | |||
|
|
|||
| // [START build_service | |||
There was a problem hiding this comment.
Missing a trailing ]
|
Sorry for being so sloppy! All looks good to me, though this might clash with #30. |
|
No worries -- it's easy for me to check because the docs build fails if there are bad regions. We went through several iterations on our snippets before we figured this out. |
|
@jmdobry could you take a look and merge if it looks ok? |
|
Squash into 1 commit and I'll merge. |
- Correct typo in snippet region. - Installation instructions should not be in build_service snippet. - Batch ops included too much extra info.
|
Squashed. |
jmdobry
added a commit
that referenced
this pull request
Nov 18, 2015
Update gcloud-node datastore snippets
grayside
pushed a commit
that referenced
this pull request
Oct 26, 2022
grayside
pushed a commit
that referenced
this pull request
Nov 3, 2022
kweinmeister
pushed a commit
that referenced
this pull request
Nov 7, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
kweinmeister
pushed a commit
that referenced
this pull request
Nov 8, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
rogerthatdev
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/nodejs-workflows/compare/v1.0.2...v1.1.0) (2021-01-09) ### Features * adds style enumeration ([#30](https://www.github.com/googleapis/nodejs-workflows/issues/30)) ([de3c259](https://www.github.com/googleapis/nodejs-workflows/commit/de3c259d08dae7edd775310c0db35fa089f58db3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/nodejs-workflows/compare/v1.0.2...v1.1.0) (2021-01-09) ### Features * adds style enumeration ([#30](https://www.github.com/googleapis/nodejs-workflows/issues/30)) ([de3c259](https://www.github.com/googleapis/nodejs-workflows/commit/de3c259d08dae7edd775310c0db35fa089f58db3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
rogerthatdev
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/nodejs-workflows/compare/v1.0.2...v1.1.0) (2021-01-09) ### Features * adds style enumeration ([#30](https://www.github.com/googleapis/nodejs-workflows/issues/30)) ([de3c259](https://www.github.com/googleapis/nodejs-workflows/commit/de3c259d08dae7edd775310c0db35fa089f58db3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 12, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 18, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 18, 2022
kweinmeister
pushed a commit
that referenced
this pull request
Nov 18, 2022
* Initial audio_profile.js, no yaargs yet * Initial Commit of audio_profile.js, no yaargs yet * Initial Commit for audioProfile.js; yaargs Command line, .ava tests * Fixed .ava tests * Audio Profiles working * delete older audio_profile.js * Updated Readme to reflect audioProfile.js * updated audio profile * moved audio profile * updated audio profile * Fixed eslint * Updated audioProfile.js * cleaned up audioProfile.test.js * Added space descriptive comments
NimJay
pushed a commit
that referenced
this pull request
Nov 18, 2022
jsimonweb
pushed a commit
to jsimonweb/nodejs-docs-samples
that referenced
this pull request
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.