Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanner samples #313

Merged
merged 3 commits into from
Feb 14, 2017
Merged

Spanner samples #313

merged 3 commits into from
Feb 14, 2017

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Feb 14, 2017

(FYI these were already reviewed by @jmdobry. @jonparrott, these should be good to merge - but feel free to skim them + verify.)

@ace-n ace-n requested a review from theacodes February 14, 2017 18:40
theacodes
theacodes reviewed Feb 14, 2017
View reviewed changes
.gitignore Outdated
@@ -1,3 +1,6 @@
.DS_Store
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes in your global gitignore, not in the repositories.

@jmdobry jmdobry self-requested a review February 14, 2017 18:43
jmdobry
jmdobry requested changes Feb 14, 2017
View reviewed changes
Copy link
Member

@jmdobry jmdobry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to sync package.json files via scrpts/unify

jmdobry
jmdobry approved these changes Feb 14, 2017
View reviewed changes
Copy link
Member

@jmdobry jmdobry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but only because the test script isn't smart enough to recognize new tests. The spanner tests won't actually run until this is merged.

@ace-n ace-n merged commit dfc3639 into master Feb 14, 2017
@ace-n ace-n deleted the spanner-samples branch April 5, 2017 01:07
This was referenced Dec 23, 2020
Open
Open
Open
NimJay pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore: release 2.1.0 (#313)
3d82ed0 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@NimJay NimJay mentioned this pull request Nov 11, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore: release 2.1.0 (#313)
74dc0cd 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@release-please
chore: release 2.1.2 (#312)
ec304e1 
🤖 I have created a release \*beep\* \*boop\* 
---
### [2.1.2](https://www.github.com/googleapis/nodejs-scheduler/compare/v2.1.1...v2.1.2) (2020-11-25)


### Bug Fixes

* **browser:** check for fetch on window ([#313](https://www.github.com/googleapis/nodejs-scheduler/issues/313)) ([5a7840a](https://www.github.com/googleapis/nodejs-scheduler/commit/5a7840acbe5cbd96be701c8d06a3ec350bf45cc1))
* do not modify options object, use defaultScopes ([#305](https://www.github.com/googleapis/nodejs-scheduler/issues/305)) ([7f8b30c](https://www.github.com/googleapis/nodejs-scheduler/commit/7f8b30c165d3de8beebb0e6704535b4eed7d817d))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@release-please
chore: release 2.1.2 (#312)
b8ffdad 
🤖 I have created a release \*beep\* \*boop\* 
---
### [2.1.2](https://www.github.com/googleapis/nodejs-scheduler/compare/v2.1.1...v2.1.2) (2020-11-25)


### Bug Fixes

* **browser:** check for fetch on window ([#313](https://www.github.com/googleapis/nodejs-scheduler/issues/313)) ([5a7840a](https://www.github.com/googleapis/nodejs-scheduler/commit/5a7840acbe5cbd96be701c8d06a3ec350bf45cc1))
* do not modify options object, use defaultScopes ([#305](https://www.github.com/googleapis/nodejs-scheduler/issues/305)) ([7f8b30c](https://www.github.com/googleapis/nodejs-scheduler/commit/7f8b30c165d3de8beebb0e6704535b4eed7d817d))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@release-please
chore: release 2.1.2 (#312)
e9ce5fe 
🤖 I have created a release \*beep\* \*boop\* 
---
### [2.1.2](https://www.github.com/googleapis/nodejs-scheduler/compare/v2.1.1...v2.1.2) (2020-11-25)


### Bug Fixes

* **browser:** check for fetch on window ([#313](https://www.github.com/googleapis/nodejs-scheduler/issues/313)) ([5a7840a](https://www.github.com/googleapis/nodejs-scheduler/commit/5a7840acbe5cbd96be701c8d06a3ec350bf45cc1))
* do not modify options object, use defaultScopes ([#305](https://www.github.com/googleapis/nodejs-scheduler/issues/305)) ([7f8b30c](https://www.github.com/googleapis/nodejs-scheduler/commit/7f8b30c165d3de8beebb0e6704535b4eed7d817d))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ace-n pushed a commit that referenced this pull request Nov 15, 2022
@release-please
chore: release 2.1.2 (#312)
67e544e 
🤖 I have created a release \*beep\* \*boop\* 
---
### [2.1.2](https://www.github.com/googleapis/nodejs-scheduler/compare/v2.1.1...v2.1.2) (2020-11-25)


### Bug Fixes

* **browser:** check for fetch on window ([#313](https://www.github.com/googleapis/nodejs-scheduler/issues/313)) ([5a7840a](https://www.github.com/googleapis/nodejs-scheduler/commit/5a7840acbe5cbd96be701c8d06a3ec350bf45cc1))
* do not modify options object, use defaultScopes ([#305](https://www.github.com/googleapis/nodejs-scheduler/issues/305)) ([7f8b30c](https://www.github.com/googleapis/nodejs-scheduler/commit/7f8b30c165d3de8beebb0e6704535b4eed7d817d))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@kweinmeister kweinmeister mentioned this pull request Nov 18, 2022
Merged
kweinmeister pushed a commit that referenced this pull request Nov 18, 2022
@release-please @bcoe
chore: release 2.1.1 (#313)
f084c97
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@bcoe
Revert "samples: update getSecret sample to include version (#311)" (#…
3635d98 
…313)

This reverts commit ddf8546fa576b36c6094e73aad8181c102ff5f41.
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 18, 2022
Merged
pattishin pushed a commit that referenced this pull request Nov 18, 2022
@suryaguthikonda @gcf-owl-bot
feat(samples): add create-featurestore samples (#317)
28c3182 
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): added create-featurestore sample (#313)

* feat(samples): added variation of create-featurestore sample (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 18, 2022
@suryaguthikonda @gcf-owl-bot @junkourata
feat(samples): add remaining featurestore api samples (#338)
1cab5c0 
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add remaining featurestore api samples (#313)

* feat(samples): add remaining featurestore apis samples (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(samples): changed timeout of featurestore apis samples (#313)

* feat(samples): update featurestore-samples.test.js (#313)

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 18, 2022
@suryaguthikonda @junkourata @gcf-owl-bot
feat(samples): add entity type apis samples (#339)
2a5baca 
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add entity type apis samples (#313)

* feat(samples): changed timeout for entity type apis samples (#313)

* feat(samples): update entity-type-samples.test.js (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 18, 2022
@suryaguthikonda @gcf-owl-bot @junkourata
feat(samples): add feature apis samples (#340)
e23b2ff 
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add feature apis samples (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(samples): updated feature-samples.test.js (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 18, 2022
@suryaguthikonda @gcf-owl-bot @junkourata
feat(samples): add feature values apis samples (#341)
bf6b6d8 
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add feature-values apis samples (#313)

* feat(samples): add feature values apis samples (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(samples): update dependency featurevalues apis (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 22, 2022
@suryaguthikonda @gcf-owl-bot @pattishin
feat(samples): add create-featurestore samples (#317)
121b68f 
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): added create-featurestore sample (#313)

* feat(samples): added variation of create-featurestore sample (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 22, 2022
@suryaguthikonda @gcf-owl-bot
@junkourata @pattishin
feat(samples): add remaining featurestore api samples (#338)
24a8ba0 
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add remaining featurestore api samples (#313)

* feat(samples): add remaining featurestore apis samples (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(samples): changed timeout of featurestore apis samples (#313)

* feat(samples): update featurestore-samples.test.js (#313)

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 22, 2022
@suryaguthikonda @junkourata
@gcf-owl-bot @pattishin
feat(samples): add entity type apis samples (#339)
b92bdec 
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add entity type apis samples (#313)

* feat(samples): changed timeout for entity type apis samples (#313)

* feat(samples): update entity-type-samples.test.js (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 22, 2022
@suryaguthikonda @gcf-owl-bot
@junkourata @pattishin
feat(samples): add feature apis samples (#340)
f08ea11 
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add feature apis samples (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(samples): updated feature-samples.test.js (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 22, 2022
@suryaguthikonda @gcf-owl-bot
@junkourata @pattishin
feat(samples): add feature values apis samples (#341)
68a5c33 
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add feature-values apis samples (#313)

* feat(samples): add feature values apis samples (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(samples): update dependency featurevalues apis (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes left review comments

@jmdobry jmdobry jmdobry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ace-n @theacodes @jmdobry