Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tpu_vm_create_topology/startup_script #3902

Merged
merged 3 commits into from
Dec 3, 2024
Merged

feat: add tpu_vm_create_topology/startup_script #3902

merged 3 commits into from
Dec 3, 2024

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Oct 15, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. api: tpu Issues related to the Cloud TPU API. labels Oct 15, 2024
@gryczj gryczj requested review from a team as code owners October 15, 2024 20:28
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Oct 15, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 15, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 15, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 15, 2024
@gryczj gryczj changed the title feat: add tpu_vm_create_topology feat: add tpu_vm_create_topology/startup_script Oct 15, 2024
Copy link

snippet-bot bot commented Oct 15, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gryczj gryczj force-pushed the vm_topology branch 7 times, most recently from 65747dd to f2a70de Compare October 16, 2024 11:49
@gryczj gryczj force-pushed the vm_topology branch 5 times, most recently from 2aeb9bd to 54683f2 Compare October 24, 2024 12:56

const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
const cwd = path.join(__dirname, '..');

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From time to time there is an issue with Enforcer when running the tests, but it is not related to the implementation.
GoogleError: GCE Enforcer is deleting necessary Cloud TPU infrastructure resources in this project. Please opt out of GCE Enforcer for this project. [FIREWALLS is deleted]

@gryczj gryczj force-pushed the vm_topology branch 10 times, most recently from 51f638a to 276b837 Compare October 31, 2024 09:22
@gryczj gryczj requested a review from a team as a code owner October 31, 2024 09:22
@gryczj gryczj marked this pull request as draft November 12, 2024 09:13
@gryczj gryczj marked this pull request as ready for review November 12, 2024 11:40
@gryczj
Copy link
Contributor Author

gryczj commented Nov 12, 2024

Due to high costs of TPU Nodes, it was decided to use mocks in the tests.

@gryczj gryczj force-pushed the vm_topology branch 2 times, most recently from 83936ba to 13b440c Compare November 21, 2024 08:50
@gryczj gryczj requested a review from iennae November 22, 2024 13:34
@gryczj gryczj force-pushed the vm_topology branch 2 times, most recently from 690834d to cd20e0c Compare November 28, 2024 09:08
@gryczj gryczj requested a review from a team as a code owner December 3, 2024 08:31
@gryczj gryczj merged commit 68c11ef into main Dec 3, 2024
136 checks passed
@gryczj gryczj deleted the vm_topology branch December 3, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: tpu Issues related to the Cloud TPU API. api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants