-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compute_consistency_group_clone/stop_replication #3920
base: main
Are you sure you want to change the base?
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gryczj and reviewers,
I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:
This pull request adds a new sample demonstrating how to clone disks from a Compute Engine consistency group. The main changes are the addition of compute/disks/consistencyGroups/consistencyGroupClone.js
, which contains the code for cloning disks, and compute/test/consistencyGroupClone.test.js
, which includes unit tests for the new functionality. The sample uses the @google-cloud/compute
library to interact with the Google Cloud Compute Engine API. The intent is to provide a clear and concise example of this functionality for Node.js developers.
If there's anything unclear or missing from this summary, please let me know. I'll provide a more thorough review shortly.
And now, a little haiku to lighten the mood:
Code flows like a stream,
Tests ensure the path is clear,
Clones spring forth anew.
Thanks!
f52b88c
to
c67030a
Compare
0ae6392
to
cc86740
Compare
@gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request introduces two new functionalities related to Compute Engine consistency groups: cloning disks from a consistency group and stopping replication for a consistency group. The code is well-structured and the tests are comprehensive. However, there are a few minor suggestions for improvement.
It's good practice to include a usage example in the README to demonstrate how to use these new functions. Also, consider adding system tests to verify the integration with the actual Compute Engine API.
0c59f12
to
ec43458
Compare
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.