Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compute_consistency_group_clone/stop_replication #3920

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Nov 19, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj requested review from a team as code owners November 19, 2024 11:53
Copy link

snippet-bot bot commented Nov 19, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Nov 19, 2024
Copy link
Contributor

@code-review-assist-experimental code-review-assist-experimental bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gryczj and reviewers,

I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:

This pull request adds a new sample demonstrating how to clone disks from a Compute Engine consistency group. The main changes are the addition of compute/disks/consistencyGroups/consistencyGroupClone.js, which contains the code for cloning disks, and compute/test/consistencyGroupClone.test.js, which includes unit tests for the new functionality. The sample uses the @google-cloud/compute library to interact with the Google Cloud Compute Engine API. The intent is to provide a clear and concise example of this functionality for Node.js developers.

If there's anything unclear or missing from this summary, please let me know. I'll provide a more thorough review shortly.

And now, a little haiku to lighten the mood:

Code flows like a stream,
Tests ensure the path is clear,
Clones spring forth anew.

Thanks!

@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 19, 2024
@gryczj gryczj force-pushed the compute_consistency_group_clone branch from f52b88c to c67030a Compare November 19, 2024 11:54
@gryczj gryczj changed the title feat: compute_consistency_group_clone feat: compute_consistency_group_clone/stop_replication Nov 20, 2024
@gryczj gryczj force-pushed the compute_consistency_group_clone branch from 0ae6392 to cc86740 Compare November 20, 2024 12:23
@iennae
Copy link
Contributor

iennae commented Nov 21, 2024

@gemini review

Copy link
Contributor

@code-review-assist-experimental code-review-assist-experimental bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request introduces two new functionalities related to Compute Engine consistency groups: cloning disks from a consistency group and stopping replication for a consistency group. The code is well-structured and the tests are comprehensive. However, there are a few minor suggestions for improvement.

It's good practice to include a usage example in the README to demonstrate how to use these new functions. Also, consider adding system tests to verify the integration with the actual Compute Engine API.

@gryczj gryczj force-pushed the compute_consistency_group_clone branch from 0c59f12 to ec43458 Compare November 21, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants