Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uploaded/updated logic for Cloud Storage #400

Merged
merged 3 commits into from
Jun 16, 2017
Merged

Fix uploaded/updated logic for Cloud Storage #400

merged 3 commits into from
Jun 16, 2017

Commits on Jun 11, 2017

  1. Fix uploaded/updated logic for Cloud Storage. 

    The metageneration attribute seems to be a string and not a number. The
strict comparison with 1 in the if/else inverted the logic that
separated file uploads from metadata updates.
    @maxbbraun
    maxbbraun committed Jun 11, 2017
    Configuration menu
    Copy the full SHA
    535e2c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2017

  1. Change metageneration attribute type to string in tests 

    Cloud Function invocations are receiving strings instead of numbers.
    @maxbbraun
    maxbbraun committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    b2449f4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into master

    @maxbbraun
    maxbbraun authored Jun 16, 2017
    Configuration menu
    Copy the full SHA
    c5ce278 View commit details
    Browse the repository at this point in the history