-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(genai): nano-banana-samples #4184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): nano-banana-samples #4184
Conversation
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @Guiners, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Node.js samples for the Google GenAI SDK by introducing a suite of new examples focused on advanced image generation and model tuning. The additions demonstrate how to leverage the "gemini-2.5-flash-image-preview" model for tasks like image editing, multi-image generation, and creating rich, illustrated content. Furthermore, a dedicated sample for virtual try-on capabilities and another for initiating and monitoring Gemini model tuning jobs have been added. These updates aim to provide comprehensive and up-to-date demonstrations of the SDK's multimedia and customization features. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a comprehensive set of new samples for the Google GenAI SDK, focusing on image generation and model tuning capabilities. The changes include new sample files, corresponding tests, and updates to existing code and dependencies. My review focuses on improving code quality by addressing hardcoded values, removing debug logs, fixing typos, and enhancing test coverage and implementation patterns for better maintainability and robustness. There are a few key areas for improvement, including a critical issue with a region tag and a high-severity test regression.
genai/image-generation/imggen-mmflash-multiple-imgs-with-txt.js
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…-assist[bot] Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This model is only available on globe endpoints.
…ample/september-samples
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.