Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Kokoro tests that fail locally #655

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Delete Kokoro tests that fail locally #655

merged 1 commit into from
Jun 13, 2018

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Jun 12, 2018 •
edited
Loading

Only leave in tests that pass locally.

For almost all tests, run only npm run, do not deploy to App Engine.
Only for the tests in test-deployment, check the full deployment.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2018
@codecov
Copy link

codecov bot commented Jun 13, 2018 •
edited
Loading

Codecov Report

Merging #655 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #655   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a427810...be17b7f. Read the comment docs.

@fhinkel
Delete Kokoro tests that fail locally
be17b7f 
For almost all tests, run only `npm run`, do not deploy to App Engine.
Only for the tests in `test-deployment`, check the full deployment.
@fhinkel fhinkel merged commit 11babe2 into master Jun 13, 2018
@fhinkel fhinkel deleted the DeleteBrokenKokoro branch June 13, 2018 22:53
grayside pushed a commit that referenced this pull request Oct 26, 2022
@pattishin
fix: wrapping param inSeconds with parseInt to ensure correct addition (
944fbbf 
#655)
@grayside grayside mentioned this pull request Oct 26, 2022
Merged
grayside pushed a commit that referenced this pull request Nov 3, 2022
@pattishin @grayside
fix: wrapping param inSeconds with parseInt to ensure correct addition (
6b3db72 
#655)
kweinmeister pushed a commit that referenced this pull request Nov 10, 2022
@release-please
chore(main): release 3.0.2 (#655)
229e1fa 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@kweinmeister kweinmeister mentioned this pull request Nov 10, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore(main): release 3.0.2 (#655)
bcaa858 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore(main): release 3.0.2 (#655)
65602e3 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@summer-ji-eng @gcf-owl-bot @alexander-fenster
fix(deps): update google-gax with http grpc status code mapping (#655)
458fe2e 
* test: update google-gax preview change

* fix system test

* update sample dependency

* revert version

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update package.json

release related change in google-gax

* chore: run tests on Node 16

* chore: exclude ci.yaml

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: run on Node 16

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Fenster <fenster@google.com>
This was referenced Nov 14, 2022
Closed
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
test: cleanup resources from tests (#655)
69715c5 

Fixes #652  🦕
@ace-n ace-n mentioned this pull request Nov 17, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
test: cleanup resources from tests (#655)
647a7af 

Fixes #652  🦕
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
test: cleanup resources from tests (#655)
2aba436 

Fixes #652  🦕
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
test: cleanup resources from tests (#655)
fb1c017 

Fixes #652  🦕
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
test: cleanup resources from tests (#655)
5dbf0b2 

Fixes #652  🦕
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@release-please
chore: release 3.1.1 (#655)
d1472ac 
🤖 I have created a release \*beep\* \*boop\* 
---
### [3.1.1](https://www.github.com/googleapis/nodejs-dialogflow/compare/v3.1.0...v3.1.1) (2020-07-23)


### Bug Fixes

* publish missing client config annotations ([#653](https://www.github.com/googleapis/nodejs-dialogflow/issues/653)) ([b368797](https://www.github.com/googleapis/nodejs-dialogflow/commit/b36879723fd3aeab0c158d3ab76a5aa6505498e1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@release-please
chore: release 3.1.1 (#655)
79c26f6 
🤖 I have created a release \*beep\* \*boop\* 
---
### [3.1.1](https://www.github.com/googleapis/nodejs-dialogflow/compare/v3.1.0...v3.1.1) (2020-07-23)


### Bug Fixes

* publish missing client config annotations ([#653](https://www.github.com/googleapis/nodejs-dialogflow/issues/653)) ([b368797](https://www.github.com/googleapis/nodejs-dialogflow/commit/b36879723fd3aeab0c158d3ab76a5aa6505498e1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 18, 2022
Merged
NimJay pushed a commit that referenced this pull request Nov 18, 2022
@release-please @NimJay
chore: release 3.1.1 (#655)
adf1923 
🤖 I have created a release \*beep\* \*boop\* 
---
### [3.1.1](https://www.github.com/googleapis/nodejs-dialogflow/compare/v3.1.0...v3.1.1) (2020-07-23)


### Bug Fixes

* publish missing client config annotations ([#653](https://www.github.com/googleapis/nodejs-dialogflow/issues/653)) ([b368797](https://www.github.com/googleapis/nodejs-dialogflow/commit/b36879723fd3aeab0c158d3ab76a5aa6505498e1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@summer-ji-eng @gcf-owl-bot @alexander-fenster
fix(deps): update google-gax with http grpc status code mapping (#655)
d7725cb 
* test: update google-gax preview change

* fix system test

* update sample dependency

* revert version

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update package.json

release related change in google-gax

* chore: run tests on Node 16

* chore: exclude ci.yaml

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: run on Node 16

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Fenster <fenster@google.com>
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@summer-ji-eng @gcf-owl-bot @alexander-fenster
fix(deps): update google-gax with http grpc status code mapping (#655)
8967eea 
* test: update google-gax preview change

* fix system test

* update sample dependency

* revert version

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update package.json

release related change in google-gax

* chore: run tests on Node 16

* chore: exclude ci.yaml

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: run on Node 16

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Fenster <fenster@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SurferJeffAtGoogle SurferJeffAtGoogle SurferJeffAtGoogle approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhinkel @SurferJeffAtGoogle @googlebot