-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tasks Samples for App Engine #676
Conversation
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
=======================================
Coverage 48.52% 48.52%
=======================================
Files 1 1
Lines 68 68
=======================================
Hits 33 33
Misses 35 35 Continue to review full report at Codecov.
|
const test = require(`ava`); | ||
const tools = require(`@google-cloud/nodejs-repo-tools`); | ||
|
||
test.before(tools.stubConsole); | ||
test.after.always(tools.restoreConsole); | ||
const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fit this in one line or is it too long? If it is too long, I think it should be written as
const {runAsync} =
require(...);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
created can be listed with `gcloud alpha tasks queues list`. | ||
|
||
``` | ||
export QUEUE_ID=my-appengine-queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? Further down we check for GCP_QUEUE
* update license * updated with client library * passing tests * update env var for QUEUE * upgrade packages * update license * updated with client library * passing tests * update env var for QUEUE * upgrade packages
* update license * updated with client library * passing tests * update env var for QUEUE * upgrade packages * update license * updated with client library * passing tests * update env var for QUEUE * upgrade packages
* test: changes AutoML v1beta1 model for v1 model * test: changed asserts
* test: changes AutoML v1beta1 model for v1 model * test: changed asserts
* test: changes AutoML v1beta1 model for v1 model * test: changed asserts
* test: changes AutoML v1beta1 model for v1 model * test: changed asserts
* test: changes AutoML v1beta1 model for v1 model * test: changed asserts
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
No description provided.