[KMS] Generalizing KMS samples for GCS docs #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Aug 10, 2018
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
=======================================
Coverage 55.17% 55.17%
=======================================
Files 1 1
Lines 58 58
=======================================
Hits 32 32
Misses 26 26Continue to review full report at Codecov.
|
|
Thanks @JustinBeckwith |
|
Merging as failed test is not related to this sample. (Cloud SQL for PostgreSQL failure) |
This was referenced Jan 31, 2020
This was referenced Apr 7, 2022
Open
Open
Open
Open
Open
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
Change-Id: I4e604288729e77a2bc8a31c749a89ee662cb3ff8 Fixes #698 🦕
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [6.2.7](https://www.github.com/googleapis/nodejs-translate/compare/v6.2.6...v6.2.7) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#711](https://www.github.com/googleapis/nodejs-translate/issues/711)) ([87604a3](https://www.github.com/googleapis/nodejs-translate/commit/87604a30f57186c90e8edfe7a3259c41da8c03d2)) * increase timeout for batch translate document ([#708](https://www.github.com/googleapis/nodejs-translate/issues/708)) ([ef154ad](https://www.github.com/googleapis/nodejs-translate/commit/ef154ad287820890a4aaedbf40e91b1cb2f798cc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
Change-Id: I4e604288729e77a2bc8a31c749a89ee662cb3ff8 Fixes #698 🦕
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [6.2.7](https://www.github.com/googleapis/nodejs-translate/compare/v6.2.6...v6.2.7) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#711](https://www.github.com/googleapis/nodejs-translate/issues/711)) ([87604a3](https://www.github.com/googleapis/nodejs-translate/commit/87604a30f57186c90e8edfe7a3259c41da8c03d2)) * increase timeout for batch translate document ([#708](https://www.github.com/googleapis/nodejs-translate/issues/708)) ([ef154ad](https://www.github.com/googleapis/nodejs-translate/commit/ef154ad287820890a4aaedbf40e91b1cb2f798cc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
Change-Id: I4e604288729e77a2bc8a31c749a89ee662cb3ff8 Fixes #698 🦕
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [6.2.7](https://www.github.com/googleapis/nodejs-translate/compare/v6.2.6...v6.2.7) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#711](https://www.github.com/googleapis/nodejs-translate/issues/711)) ([87604a3](https://www.github.com/googleapis/nodejs-translate/commit/87604a30f57186c90e8edfe7a3259c41da8c03d2)) * increase timeout for batch translate document ([#708](https://www.github.com/googleapis/nodejs-translate/issues/708)) ([ef154ad](https://www.github.com/googleapis/nodejs-translate/commit/ef154ad287820890a4aaedbf40e91b1cb2f798cc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
Change-Id: I4e604288729e77a2bc8a31c749a89ee662cb3ff8 Fixes #698 🦕
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [6.2.7](https://www.github.com/googleapis/nodejs-translate/compare/v6.2.6...v6.2.7) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#711](https://www.github.com/googleapis/nodejs-translate/issues/711)) ([87604a3](https://www.github.com/googleapis/nodejs-translate/commit/87604a30f57186c90e8edfe7a3259c41da8c03d2)) * increase timeout for batch translate document ([#708](https://www.github.com/googleapis/nodejs-translate/issues/708)) ([ef154ad](https://www.github.com/googleapis/nodejs-translate/commit/ef154ad287820890a4aaedbf40e91b1cb2f798cc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
Change-Id: I4e604288729e77a2bc8a31c749a89ee662cb3ff8 Fixes #698 🦕
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [6.2.7](https://www.github.com/googleapis/nodejs-translate/compare/v6.2.6...v6.2.7) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#711](https://www.github.com/googleapis/nodejs-translate/issues/711)) ([87604a3](https://www.github.com/googleapis/nodejs-translate/commit/87604a30f57186c90e8edfe7a3259c41da8c03d2)) * increase timeout for batch translate document ([#708](https://www.github.com/googleapis/nodejs-translate/issues/708)) ([ef154ad](https://www.github.com/googleapis/nodejs-translate/commit/ef154ad287820890a4aaedbf40e91b1cb2f798cc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm removing global location mention to generalize sample for GCS CMEK documentation. The sample is used to show developers how to set an IAM policy on a KMS key, but global location aren't supported so I' want to generalize that part of the sample.
PTAL, thank you!