Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storage in auth sample #750

Merged
merged 2 commits into from
Oct 6, 2018
Merged

Update storage in auth sample #750

merged 2 commits into from
Oct 6, 2018

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Sep 28, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2018
@fhinkel
Copy link
Contributor Author

fhinkel commented Sep 28, 2018

Related: googleapis/nodejs-storage#415

@fhinkel fhinkel added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2018
@fhinkel fhinkel added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2018
@fhinkel fhinkel requested a review from ace-n October 1, 2018 20:09
@fhinkel fhinkel added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2018
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but isn't this more of a @crwilcox thing?)

@fhinkel fhinkel merged commit b232e96 into master Oct 6, 2018
@fhinkel fhinkel deleted the fixAuthSample branch October 6, 2018 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants