Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests #284

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Fix e2e tests #284

merged 1 commit into from
Feb 26, 2019

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Feb 26, 2019

e2e tests send request against the live app living at
https://${opts.version}-dot-${opts.project}.appspot.com;

The test config relies on opts.project, which we configure via
an environment variable.

Note that only our tests use $GCLOUD_PROJECT, it is not used in the app.

e2e tests send request against the live app living at
`https://${opts.version}-dot-${opts.project}.appspot.com`;

The test config relies on `opts.project`, which we configure via
an environment variable.

Note that only our tests use $GCLOUD_PROJECT, it is not used in the app.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants