-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample for user auth with IAP #334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.
We only use caps for const
variables. I'm thinking though that we should make them const
and initialize them before the first request, i.e., before app.get()
. Would you like to make that change? Otherwise I'm happy to.
Fixed.
I'll take a stab at it. For some reason, I'd rather have the global variables mediated through a function call, but I can't really justify that. |
Actually, since initializing them involves asynchronous calls, it seems possible that the response to app.get would be created before those variables were initialized. So I'd prefer to leave the code as is. |
No description provided.