Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample for user auth with IAP #334

Merged
merged 4 commits into from
Sep 1, 2019
Merged

Sample for user auth with IAP #334

merged 4 commits into from
Sep 1, 2019

Conversation

engelke
Copy link
Contributor

@engelke engelke commented Aug 13, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2019
@engelke engelke requested a review from fhinkel August 13, 2019 16:36
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

We only use caps for const variables. I'm thinking though that we should make them const and initialize them before the first request, i.e., before app.get(). Would you like to make that change? Otherwise I'm happy to.

@engelke
Copy link
Contributor Author

engelke commented Aug 15, 2019

We only use caps for const variables.

Fixed.

I'm thinking though that we should make them const and initialize them before the first request, i.e., before app.get(). Would you like to make that change? Otherwise I'm happy to.

I'll take a stab at it. For some reason, I'd rather have the global variables mediated through a function call, but I can't really justify that.

@engelke
Copy link
Contributor Author

engelke commented Aug 15, 2019

Actually, since initializing them involves asynchronous calls, it seems possible that the response to app.get would be created before those variables were initialized. So I'd prefer to leave the code as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants