Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use async/await in authenticating-users #344

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Use async/await in authenticating-users #344

merged 3 commits into from
Sep 19, 2019

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Sep 18, 2019

Drive-by fix: Use camel case for variables.

@fhinkel
Use async/await in authenticating-users
3031ac8 
Drive-by fix: Use camel case for variables.
@fhinkel fhinkel requested a review from engelke September 18, 2019 17:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2019
engelke
engelke approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhinkel fhinkel merged commit 1dd364e into master Sep 19, 2019
@fhinkel fhinkel deleted the async1 branch September 19, 2019 01:12
This was referenced Dec 14, 2023
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhinkel @engelke @googlebot