Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register frontendproxy service with service directory for uptime checks #82

Merged
merged 1 commit into from
May 17, 2024

Conversation

dashpole
Copy link
Collaborator

Change service to an internal load balancer so it can be used for uptime checks.

Register the service with service directory.

I've already applied both the updated service and the service directory registration to the cluster, and the uptime checks work properly.

@damemi
Copy link
Contributor

damemi commented May 17, 2024

I've already applied both the updated service and the service directory registration to the cluster, and the uptime checks work properly.

in the future, we should try not to test changes like this in the shared cluster and use a personal test project instead

@dashpole
Copy link
Collaborator Author

@dashpole dashpole merged commit 63d3864 into GoogleCloudPlatform:main May 17, 2024
27 of 28 checks passed
@dashpole dashpole deleted the uptime_checks branch May 17, 2024 16:11
@renovate-bot renovate-bot mentioned this pull request Aug 8, 2024
1 task
damemi pushed a commit to damemi/gcp-opentelemetry-demo that referenced this pull request Aug 26, 2024
damemi pushed a commit to damemi/gcp-opentelemetry-demo that referenced this pull request Aug 26, 2024
damemi pushed a commit to damemi/gcp-opentelemetry-demo that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants