Use OC stackdriver exporter to capture self observability metrics as GCM protos #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
self-obs-oc-go-exporter
branch
2 times, most recently
from
70e9e70 to
fb6c2eb
Compare
aabmass
commented
Jan 20, 2022
aabmass
commented
Jan 20, 2022
| @@ -22,14 +22,10 @@ message MetricExpectFixture { | |||
| repeated google.monitoring.v3.CreateTimeSeriesRequest create_time_series_requests = 1; | |||
| repeated google.monitoring.v3.CreateMetricDescriptorRequest create_metric_descriptor_requests = 2; | |||
| repeated google.monitoring.v3.CreateTimeSeriesRequest create_service_time_series_requests = 3; | |||
| repeated SelfObservabilityMetric self_observability_metrics = 4; | |||
| SelfObservabilityMetric self_observability_metrics = 4; | |||
There was a problem hiding this comment.
The fields in SelfObservabilityMetric could be flattened into this message, but I feel like nesting the messages makes the JSON easier to read than a long name.
aabmass
force-pushed
the
self-obs-oc-go-exporter
branch
from
fb6c2eb to
d3c18d0
Compare
dashpole
reviewed
Jan 20, 2022
Yes it doesn't fix that problem, but i was going down a rabbit hole of trying to add metric type and histogram bucket options to the This is also better if/when we switch these self obs metrics to OTel instrumentation, we can just use our OTel exporter to capture the same metrics rather than write conversion to a bespoke protobuf format. |
I think i've almost connected the dots. How does using opencensus relate to using the GCM proto? |
Do you mean using the OpenCensus stackdriver exporter? It's just the way to serialize OC metrics to GCM protobufs. I may be misunderstanding your question |
|
Ah, ok. I got it now. We are essentially changing from opencensus to GCM protos. |
dashpole
approved these changes
Jan 20, 2022
Yup. Probably should have explained that better, sorry |
dashpole
added a commit
that referenced
this pull request
Feb 2, 2022
* Skip all fixture tests (#239) * Initial structure for new pdata metrics exporter (#238) * [Metrics Rewrite] add outline with todos for fragmenting work (#240) * [Metrics Rewrite] attribute to label mapping (#243) [Metrics Rewrite] attribute to label mapping * [Metrics Rewrite] support for pdata Sum points (#242) * [Metrics Rewrite] support for pdata Sum points * update breaking-changes.md * use concatentation instead of sprintf * [Metrics Rewrite] support for pdata Gauge points (#244) * Add logic to translate metric descriptors and initial flow (#247) * Fixes from merge. * Fix tests. * Clean up test cases, re-disable integration tests. * Add summary descriptors and label descriptors. * Fix lint issues. * Some fixes from review. * Remove metric import. * Fixes from review. - Update default config method - Simplify some of my lack-of-go expertise. * Add unit test for metric domains. * Fixes from review. * Add breaking changes. * Fixes from review. * Update context to be TODO. * Add support for exponential histograms and exemplars. (#251) * Add support for exponential histograms and exemplars. * Fixes from review. * Fixes from review. * Fixes from discussion. * [Metrics Rewrite] implement monitored resource mapping (#252) * [Metrics Rewrite] implement monitored resource mapping * review fixes * [Metrics Rewrite] update breaking-changes.md for monitored resource (#255) * Add summary mapping to exporter. (#249) * Add config to call `CreateServiceTimeSeries` (#259) * Initial implementation of create service time series. * Add a test case for create service timeseries. * Add logic to auto-detect project id if not configured. * Fix from code review * Fix resource to be one that has retention policy for integration tests. * Add support for histogram to metrics exporter. (#258) BUG=210164184 * Re-enable ops-agent self-metric integration test. (#260) * [Metrics Rewrite] add ExponentialHistogram fixture (#257) * [Metrics Rewrite] add ExponentialHistogram fixture * make tests deterministic * few last changes * close channel instead of sending a message * Enable ops agent host metric integration test. (#264) - There is a bug in upstream agent-metric-processor that sets incorrect units on usage metrics (GoogleCloudPlatform/opentelemetry-operations-collector#72) - We update the expectations for inculsion of units in CreateTimeSeries - We disable metric descriptors (for now). Given the bug in agent-metric-processor, liekly ops-agent will need upstream fix for this first. * add a feature gate, which defaults to false, for using the re-written exporter (#267) * Enable Basic integration tests (#266) * Enable basic counter test. * Enable delta counter metrics. - Note: Delta counters are NOW fake-delta (i.e. cumulatives with limited time windows) * Enable non-monotonic-sum integration test. * Re-enable summary integration test and fix design issues in summary translation. - Summary exports percentiles, not quantiles - Percentiles should include similar double precision in the string. * Fix recordfixtures script to use featuregate (#270) * Skip already seen attribute keys when creating LabelDescriptors (#272) * Reenable GKE metrics agent fixtures (#271) * Update breaking-changes.md for googlecloudmonitoring/point_count self observability (#277) * Move logging to use zap-logger and set up self-observability to match collector expectations. (#275) * Enable metric prefix integraiton tests. (#274) * enable workloadapis prefix integration test. * update unknown domain metrics expect. * Add instrumentationLibraryToLabels method to metrics exporter. (#253) * Add instrumentationLibraryToLabels method to metrics exporter. BUG=https://b.corp.google.com/issues/210164355 * Remove custom_metrics_domains behaviour from metrics-exporter. * Remove dependency on go.opentelemetry.io/collector (#279) * remove dependency on go.opentelemetry.io/collector * add ocgrpc metrics to exporters' self-obs metrics (#280) * Use OC stackdriver exporter to capture self observability metrics as GCM protos (#282) * Capture ocgrpc self observability metrics (#283) * make integrationtest not internal (#285) * Remove internal/ prefix for integrationtest (#288) * Add batching support to metrics-exporter. (#286) * Add batching support to metrics-exporter. * Retry when we fail to write metric descriptors. * Re-enable workload metrics integration tests (#278) * update header year for new files (#296) * Document new CreateMetricDescriptor behavior (#294) * reenable disabled metrics test (#299) Co-authored-by: Aaron Abbott <aaronabbott@google.com> Co-authored-by: Josh Suereth <Joshua.Suereth@gmail.com> Co-authored-by: Thomas Barker <tbarker25@gmail.com> Co-authored-by: Punya Biswal <punya@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect the OC self observability metrics using the same
MetricTestServer(GCM mock server) + stackdriver exporter instead of a bespoke proto format. They now get serialized as they would be exported to GCM.