Use google CEL for custom resource mappings #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
mr-cel
branch
2 times, most recently
from
f268d26
to
3aaa77e
Compare
|
This looks like a great feature! Why wasn't it implemented in the end? |
|
This was intended to be a PoC and we decided we wanted to hear more use cases for this kind flexibility before including it. You can still pass a Go function to configure resource mappings (example) but you'll have to build your own collector (we figure 1st party use cases are already doing this). Another option would be Starlark which would probably be less clunky. IIRC, this CEL approach was also quite slow in benchmarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.