-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Cloud Trace library to v1.8.0 #550
Conversation
Should we open an upstream issue asking for the default to be changed? Or ask why the default is set the way it is? If we can avoid adding a new config surface, that seems best. It also would seem odd for us to have a different default from the upstream library. |
Upstream issue raised at googleapis/google-cloud-go#7184 |
update: we implemented this as a default setting in the upstream trace client instead. but, I think we can still use the unit tests I added here to make sure attempts are retried. once the upstream generated clients land, I'll use this PR to bump the dependency and add these tests. Holding until then |
0e7a84f
to
b84a3ca
Compare
Codecov Report
@@ Coverage Diff @@
## main #550 +/- ##
=======================================
Coverage 64.68% 64.68%
=======================================
Files 38 38
Lines 4281 4282 +1
=======================================
+ Hits 2769 2770 +1
Misses 1399 1399
Partials 113 113
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Working on deprecated import path migration (https://github.com/googleapis/google-cloud-go/blob/main/migration.md)... |
Fixes #208
This bumps the cloud trace client to v1.8.0, which offers default batch retry on failed writes.
Currently the trace client retries failed calls for
CreateSpans
but notBatchWriteSpans
.