Add support for CLOUD_SDK_ACCESS_TOKEN_PATH #775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for configuring the collector to authenticate with a token source that comes from a file defined by the CLOUD_SDK_ACCESS_TOKEN_PATH environment variable. When the token expires, the token source will refresh by reading the file again. Optionally the user can set CLOUD_SDK_ACCESS_TOKEN_EARLY_EXPIRY to control when the refresh occurs. The gcloud CLI has support for authenticating with user-supplied access tokens. See: https://issuetracker.google.com/issues/134539464#comment12 This is useful when credentials need to be generated dynamically from some centralized system that passes these scoped short-lived credentials to untrusted systems which use them to authenticate with GCP services (instead of having the untrusted system generate the credentals with some base/root credentials).
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I don't think we should include GCP auth-related code in our OTel exporters. I would recommend opening a feature request with https://github.com/googleapis/google-cloud-go. If it is accepted, then we will support it once we update the client library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for configuring the collector to authenticate with a token source that comes from a file defined by the CLOUD_SDK_ACCESS_TOKEN_PATH environment variable.
When the token expires, the token source will refresh by reading the file again. Optionally the user can set CLOUD_SDK_ACCESS_TOKEN_EARLY_EXPIRY to control when the refresh occurs.
The gcloud CLI has support for authenticating with user-supplied access tokens. See: https://issuetracker.google.com/issues/134539464#comment12
This is useful when credentials need to be generated dynamically from some centralized system that passes these scoped short-lived credentials to untrusted systems which use them to authenticate with GCP services (instead of having the untrusted system generate the credentals with some base/root credentials).