Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagator return original context if failed to extract #139

Merged
merged 4 commits into from
May 13, 2021
Merged

Propagator return original context if failed to extract #139

merged 4 commits into from
May 13, 2021

Conversation

aabmass
Copy link
Collaborator

@aabmass aabmass commented May 12, 2021 •
edited
Loading

This issue was found for OTel propagators open-telemetry/opentelemetry-python#1765

Propagators should

  • Use an empty context if none is passed
  • Only return a new modified context if it successfully extract()ed.

@google-cla google-cla bot added the cla: yes label May 12, 2021
@aabmass aabmass force-pushed the fix-propagator-1765 branch from 6a4ad2b to a4174a7 Compare May 12, 2021 20:45
@aabmass aabmass requested a review from a team May 12, 2021 20:49
@aabmass aabmass marked this pull request as ready for review May 12, 2021 20:49
@aabmass aabmass mentioned this pull request May 12, 2021
Closed
@aabmass aabmass changed the title return original context if no issue Propagator return original context if failed to extract May 13, 2021
@aabmass aabmass force-pushed the fix-propagator-1765 branch 2 times, most recently from 2754255 to 9422b68 Compare May 13, 2021 18:28
@punya punya merged commit 4f2c964 into GoogleCloudPlatform:master May 13, 2021
@aabmass aabmass deleted the fix-propagator-1765 branch May 13, 2021 19:16
@aabmass aabmass mentioned this pull request May 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@punya punya punya approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabmass @punya