confgenerator : Add otel logging support for systemd_journald receiver.
#1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscovalentecastro
force-pushed
the
fcovalente-otel-logging-systemd
branch
from
6e369a7 to
c731e31
Compare
franciscovalentecastro
changed the title
systemd_journald receiver.systemd_journald receiver.
quentinmit
reviewed
Feb 7, 2025
| @@ -682,6 +682,61 @@ func (r LoggingReceiverSystemd) Components(ctx context.Context, tag string) []fl | |||
| return input | |||
| } | |||
|
|
|||
| func (r LoggingReceiverSystemd) Pipelines(ctx context.Context) ([]otel.ReceiverPipeline, error) { | |||
| operators := []map[string]any{} | |||
| operators = append(operators, map[string]any{ | |||
There was a problem hiding this comment.
I think we should use ModifyFields here instead of using the deprecated operators option to do these manipulations.
| }) | ||
| } | ||
|
|
||
| func testSystemdLog(t *testing.T, otel bool) { |
There was a problem hiding this comment.
I'd like to see this actually test the schema of the log entries, instead of just testing that one exists.
Probably that means we should send a particular canary message to journald and then check how it is represented in Cloud Logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add otel logging support for
systemd_journaldreceiver.Related issue
b/394593541
How has this been tested?
Checklist: