fix(pipelines): file not found for marketplace snapshot test

[zijianjoy]

I found that the presubmit test has failed because it cannot find the presubmit file:

kubeflow/pipelines#7137

[zijianjoy]

cc @Bobgy

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• prow/prowjobs/kubeflow/OWNERS [zijianjoy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chensun]

Looks like alpine image doesn't contain /bin/bash by default. Maybe just use gcr.io/google.com/cloudsdktool/cloud-sdk:latest which is already used in this file?

Alternatively, I'm not sure if changing the #!/bin/bash to #!/bin/sh in manifests/gcp_marketplace/test/presubmit.sh would work.

[zijianjoy]

That is a good point, after trying gcloud, I found that it doesn't have apt which is required by presubmit.sh. So I will just use alpine because it will install bash if not exist.

[chensun]

I'm not sure if alpine comes with apt by default. Looks like you need a not-so-minimum image, I'm guessing you might need to try debian slim or something similar.

[zijianjoy]

I am able to use apt for alpine, or should I try debian slim? Will that be too big for presubmit run?

[chensun]

No, if it works, then never mind. :) Let's merge and try it out.

[chensun]

If you want to stick with alpine, that's fine by me. Maybe/bin/sh -c sh something.sh can be simplified to/bin/sh something.sh?

[zijianjoy]

After trying the scripts, I found that I need to run more than one command, please see the updated commands.

[chensun]

forgot to push?

[zijianjoy]

Sorry! I have pushed now.

[chensun]

/lgtm

Thanks!

[google-oss-prow]

@zijianjoy: Updated the job-config configmap in namespace default at cluster default using the following files:

• key kubeflow-pipelines-presubmits.yaml using file prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-presubmits.yaml

In response to this:

I found that the presubmit test has failed because it cannot find the presubmit file:

kubeflow/pipelines#7137

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.