Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

Making the default to PHP 7.2 #391

Merged
merged 9 commits into from
Dec 5, 2017
Merged

Making the default to PHP 7.2 #391

merged 9 commits into from
Dec 5, 2017

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Nov 30, 2017

No description provided.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Dec 5, 2017

The test failed with:

PHP Warning: copy(): SSL: Connection reset by peer in Command line code on line 1
echo 'ERROR: Invalid composer installer signature'
ERROR: Invalid composer installer signature

Likely a temporary errror, but better to making that part more robust.

Copy link
Member

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmatsuo tmatsuo merged commit 4454562 into master Dec 5, 2017
@tmatsuo tmatsuo deleted the 72 branch May 7, 2018 20:04
frost-byte pushed a commit to Wiser-Owl/php-docker that referenced this pull request May 9, 2021
* Making the default to PHP 7.2

* Moved the comment due to a warning for an empty continuation line

* Temporary disable the structure test on php72-custom

* Re-enabled the structure test for php72-custom

* Use asterisk for the PHP micro versions in composer.json

* Fixed the version test for 7.2.0

* PHP 7.2.0 test fixes

* Runtime Buidler test fixes

* Added google/gax dep
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants